Code Monkey home page Code Monkey logo

Comments (6)

dilame avatar dilame commented on August 17, 2024 1

There is a proper implementation of custom error classes using extend, i worked on it it several years ago

https://github.com/adriengibrat/ts-custom-error/blob/main/src/custom-error.ts#L27-L47

from effect.

tim-smart avatar tim-smart commented on August 17, 2024 1

We made YieldableError extend Inspectable which adds those methods.

I have found a way to get cause to render, while preserving the custom .toString behaviour.

We can't remove those methods until the next major version, if that is something we decide to do.

from effect.

johtso avatar johtso commented on August 17, 2024

This is really making it hard to debug issues. I wonder if there's some kind of temporary workaround?

from effect.

johtso avatar johtso commented on August 17, 2024

Related: #1651

from effect.

johtso avatar johtso commented on August 17, 2024

@tim-smart I see you added a few of the methods to the YieldableError class. Can you shed any light on why it's been accumulating these custom methods rather than just leaving the standard methods of the Error that it extends?

Would it not make more sense for the behaviour to match a vanilla Error as closely as possible unless there's a specific reason to diverge? Is there a reason that I'm missing?

from effect.

johtso avatar johtso commented on August 17, 2024

@tim-smart do you think it would make sense to open a separate issue regarding displaying of causes of unhandled yielded errors and errors logged with Effect.logError?

from effect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.