Support PromiseLike or Effect in `tryPromise` `catch` about effect HOT 5 CLOSED

Perfect. Thank you.
No idea why it was hanging jest but without the throw it seems fine.

from effect.

We seemed to have the same problem when using Effect.async to wrap it manually

from effect.

We only want to handle certain cases in the catch and die otherwise.

Note that when using tryPromise with a catch handler to return typed Errors, you are not actually handling the errors, you are just refining them to be handled elsewhere in your application in a type safe manner.

Throwing in catch is odd and I'd avoid that.

If you want to actually handle specific errors, you could use Effect.catchTag(s) subsequently.

However, for the purpose of a test, I'd actually do this completely differently and instead match on an Exit in your program e.g. using Effect.matchCause or by collecting the final Exit value of your entire program and then matching against that (e.g. using Effect.runPromiseExit).

from effect.

Yes. I understand I'm only refining them but what if all other cases mean Defect. So you're saying the catch should return BlahFailure | SomeDefectFlag and then I should die on SomeDefectFlag back in Effect land?

from effect.

There's countless ways to achieve that, e.g. you could refine and use Cause.UnknownException (which is what tryPromise also uses internally) for the fallback case.

You can then also decide to further elevate that into a defect with a subsequent flipWith and filterOrDie. Or you can capture all cases in an Exit and assert based on that (which is what I usually do).

// Effect.Effect<never, MyRefinedError, never>
const program = Effect.tryPromise({
  try: () => Promise.reject(new Error("foo")),
  catch: (cause) => {
    if (cause instanceof Error && cause.message === "foo") {
      return new MyRefinedError(cause)
    }

    return new Cause.UnknownException(cause)
  }
}).pipe(Effect.flipWith(Effect.filterOrDie((cause): cause is MyRefinedError => cause instanceof MyRefinedError, identity)))

// Exit<never, Cause.UnknownException | MyRefinedError>
const exit = await Effect.runPromiseExit(
  Effect.tryPromise({
    try: () => Promise.reject(new Error("foo")),
    catch: (cause) => {
      if (cause instanceof Error && cause.message === "foo") {
        return new MyRefinedError(cause)
      }
  
      return new Cause.UnknownException(cause)
    }
  })
)

from effect.