Code Monkey home page Code Monkey logo

Comments (5)

gcanti avatar gcanti commented on July 20, 2024

The output is fine (they are errors, and that's the stack trace), but it seems like there's a bug in expect, using

import * as assert from "node:assert"

works:

class DataTaggedError extends Data.TaggedError("DataTaggedError")<{
  msg: string
}> {}

// no error
expect({ error: new DataTaggedError({ msg: "a" }) }).toStrictEqual({ error: new DataTaggedError({ msg: "b" }) })

// error
assert.deepStrictEqual({ error: new DataTaggedError({ msg: "a" }) }, { error: new DataTaggedError({ msg: "b" }) })

class SchemaTaggedError extends S.TaggedError<SchemaTaggedError>()(
  "SchemaTaggedError",
  {
    msg: S.string
  }
) {}

// no error
expect({ error: new SchemaTaggedError({ msg: "a" }) }).toStrictEqual({ error: new SchemaTaggedError({ msg: "b" }) })

// error
assert.deepStrictEqual({ error: new SchemaTaggedError({ msg: "a" }) }, {
  error: new SchemaTaggedError({ msg: "b" })
})

from effect.

steffanek avatar steffanek commented on July 20, 2024

That's correct, and I raise an issue on vitest. Still what's the reason that:

class DataTaggedError extends Data.TaggedError("DataTaggedError")<{
  msg: string;
}> {}

const dataTaggedError = new DataTaggedError({ msg: "a" });
console.log("dataTaggedError", dataTaggedError);

Output the following (without logging the instance? where SchemaTaggedError does output the instance):

dataTaggedError DataTaggedError 
..stack trace..

from effect.

gcanti avatar gcanti commented on July 20, 2024

both are YieldableErrors:

[NodeInspectSymbol](): string {
const stack = this.stack
if (stack) {
return `${this.toString()}\n${stack.split("\n").slice(1).join("\n")}`
}
return this.toString()
}
so it depends on how this.toString() is implemented

from effect.

steffanek avatar steffanek commented on July 20, 2024

Thanks for your explanation and for pointing to the internal resource.
I will update and close this thread as soon as vitest will fixed the issue.

from effect.

steffanek avatar steffanek commented on July 20, 2024

I'm closing this issue. To make vitest expect work please follow this link: vitest issue

from effect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.