Code Monkey home page Code Monkey logo

Comments (2)

gcanti avatar gcanti commented on June 22, 2024

It seems that ts encounters difficulty inferring the correct type when optional is used tacitly:

const x = S.string.pipe(S.optional); // error

const y = pipe(S.string, S.optional); // error

This might be due to the presence of different overloads in the optional signature. In both cases above, the inferred schema is Schema<unknown, unknown>.

I'm unsure about how to resolve this issue. However, isn't tacit usage never recommended?

from effect.

mikearnaldi avatar mikearnaldi commented on June 22, 2024

It seems that ts encounters difficulty inferring the correct type when optional is used tacitly:

const x = S.string.pipe(S.optional); // error

const y = pipe(S.string, S.optional); // error

This might be due to the presence of different overloads in the optional signature. In both cases above, the inferred schema is Schema<unknown, unknown>.

I'm unsure about how to resolve this issue. However, isn't tacit usage never recommended?

While tacit usage is never recommended pipe is kind of an exceptional case, otherwise we could also say that pipe([0, 1], ReadonlyArray.map((n) => n + 1) is discouraged.

Re overloads, this is indeed the issue, namely overload selection, I think we need to decide if the reason we have overloads is absolute necessity or if we can encode what we do with overloads with a conditional return type (that would solve tacit usage).

It's up to @gcanti if you decide that overloads are needed then feel free to close the issue as "intended behaviour"

from effect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.