Code Monkey home page Code Monkey logo

Comments (6)

EdwinVW avatar EdwinVW commented on May 22, 2024 1

See commit f243358

I've also changed the SqlServerWorkshopPlanningEventSourceRepository of the WorkshopManagementAPI so its structure is identical to that of the other two repos.

from pitstop.

EdwinVW avatar EdwinVW commented on May 22, 2024

Yes that's fine - providing it also keeps working on SQL Server (which I assume is the case).

from pitstop.

EdwinVW avatar EdwinVW commented on May 22, 2024

Fixed in commit 9383def
Successfully tested these changes on SQL Server.

from pitstop.

EdwinVW avatar EdwinVW commented on May 22, 2024

Can you check whether this is sufficient to fix the issue?

from pitstop.

rouke-broersma avatar rouke-broersma commented on May 22, 2024

This is the same change we made to our fork 👍

The only difference is that we did a conn.OpenAsync(); in the new connection scope but if you say the change works fine without it on SQL server then I guess it's not neccesary? 🤷

from pitstop.

EdwinVW avatar EdwinVW commented on May 22, 2024

Yes, it makes sense to explicitly open the connection. I'll create a fix for that.

from pitstop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.