Comments (2)
I think you opened a pull request to your own repository, instead of to mine...I'm not entirely sure how to rectify that! :)
I'm definitely interested in incorporating some of your changes. I think the best way to do that would be with multiple pull requests based on individual, targeted commits. For instance, one commit (and one pull request) for standardizing line-height and margins, one for media queries, and so one.
I also noticed you added an 'r' to ET Bembo...do I have the name wrong?
from tufte-css.
Okay, let me see if I can walk my way through this. The main things I mucked around with were the typographic scale related stuff plus added some media queries so that the line lengths stay sane when the browser resizes.
As far as the ETBrembo goes - that is a typo that crept in during my editing. I have fixed it now!
On Feb 7, 2015, at 3:54 PM, Dave Liepmann [email protected] wrote:
I think you opened a pull request to your own repository, instead of to mine...I'm not entirely sure how to rectify that! :)
I'm definitely interested in incorporating some of your changes. I think the best way to do that would be with multiple pull requests based on individual, targeted commits. For instance, one commit (and one pull request) for standardizing line-height and margins, one for media queries, and so one.
I also noticed you added an 'r' to ET Bembo...do I have the name wrong?
—
Reply to this email directly or view it on GitHub.
from tufte-css.
Related Issues (20)
- navbar support/advice? HOT 1
- links look weird when highlighted HOT 2
- tufte.css and tufte.min.css have different update dates HOT 1
- Inconsistent spacing due to inline labels as sidenote numbers HOT 1
- dark mode HOT 4
- Sidenotes on list items are misaligned
- Lists in sidenotes have body-sized fonts.
- Figcaption text overlays the image on fullwidth iframe-wrapper
- Apply section style to header and footer elements, too
- Embedding superscripts breaks line height.
- Anything in the margin disappears with narrow browser window HOT 2
- Sidenote indexing HOT 8
- .margin-toggle:checked + .sidenote ... {vertical-align: ...}
- Underlines missing at certain zoom levels HOT 8
- sidenote becomes footnote
- Using srcset inside fullwidth figure renders an image that is not full width
- Darkmode background is too dark HOT 2
- Does tufte-css play nicely with screen readers? HOT 1
- Academicicons are very strangely underlined HOT 2
- Descenders for link underlines are now available without the text-shadow hack HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tufte-css.