Code Monkey home page Code Monkey logo

Comments (6)

edkolev avatar edkolev commented on July 29, 2024

Thank you for the pull request.

I would prefer not to modify all the airline themes (airline, airline_insert, airline_visual).
Also, if someone doesn't use airline's tabline feature (which is by default off), the tmux colors will not be consistent with the tabline (because tabline is not visible).

Still, I do think this is a useful addition. Could you implement it as a separate theme? For example autoload/tmuxline/themes/airline_tabline.vim. Before return-ing here https://github.com/edkolev/tmuxline.vim/blob/master/autoload/tmuxline/themes/airline_visual.vim#L12 the colors should be modified.

Then users will have to set this in vimrc let g:tmuxline_preset = 'airline_tabline'

from tmuxline.vim.

paulhybryant avatar paulhybryant commented on July 29, 2024

Sure. What is the difference between theme and preset? If I implement this as a theme, shouldn't the user specify let g:tmuxline_theme = 'airline_tabline' instead of setting g:tmuxline_preset?

Thanks,

from tmuxline.vim.

edkolev avatar edkolev commented on July 29, 2024

Sorry, I copy-pasted incorrectly. User should set g:tmuxline_theme

Let me know if you run into any issues.

from tmuxline.vim.

justmytwospence avatar justmytwospence commented on July 29, 2024

+1 either changing the theme or creating a new one

from tmuxline.vim.

paulhybryant avatar paulhybryant commented on July 29, 2024

I have updated the PR and include this as a new theme.

Thanks.

from tmuxline.vim.

paulhybryant avatar paulhybryant commented on July 29, 2024

Please take a look at the PR. Thanks,

from tmuxline.vim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.