Comments (6)
Hi, thanks for the info!
From what I've tested, funcall
works 99% of the times.
Unfortunately, some functions in evil behave differently based on what called-interactively
returns. If I remember correctly, pasting in insert state had a subtle difference in its behaviour.
However, I just did some tests with pasting in insert state without funcall-interactively
and I can't see any issues.
I'll revert the code locally to use a plain funcall
and use evil-goggles for some time, 1 week maybe. Then, if I don't see any issues, I'll re-add support for emacs 24 by removing the funcall-interactively
.
Thanks again!
from evil-goggles.
good plan, thanks !
from evil-goggles.
I ran into the following inconsistency when using funcall
instead of funcall-interactively
:
- with this text
;; This buffer is for notes you don't want to save.
;; [I]f you want to create a file, visit that file with C-x C-f,
;; then enter the text in that file's own buffer.
- press
2dd
- result with
funcall
is:
;; This buffer is for notes you don't want to save[.]
- result with
funcall-interactive
is:
[;]; This buffer is for notes you don't want to save.
The difference is in the cursor placement. The correct behaviour is the second one, funcall-interactive
.
from evil-goggles.
@vindarel with this commit 221a5ed I believe evil-goggles should work on Emacs 24.4. Please let me know if it does for you.
from evil-goggles.
I've been using my own tweak with success, this one works well too. Thanks !
from evil-goggles.
Great, thanks!
from evil-goggles.
Related Issues (20)
- goggles for custom evil-operators HOT 10
- I get this error when trying to install this with use-package. HOT 7
- Visual hints slow down bulk actions using multiple cursors (evil-mc) HOT 4
- Please don't bundle evil-tests.el HOT 2
- Evil goggles ignores faces :foreground property HOT 2
- Add visual hint for visual mode operations HOT 3
- (evil-goggles-enable-delete nil) only works in conjunction with yank HOT 6
- evil-change with surround is broken by evil-goggles HOT 2
- Hint on undo/redo is disabled HOT 3
- Visual feedback not shown in org-mode HOT 5
- Highlight changes right after leaving insert mode HOT 1
- evil-goggles is incompatible with evil-cleverparens and evil-smartparens HOT 2
- Highlight doesn't pulse if using emacsclient HOT 1
- Very slow on windows
- evil-paste-pop, highlight remains and can't be cleared easily HOT 6
- Problems with Doom One theme
- Causes `evil-paste-pop` to stop working HOT 5
- Fix compilation warnings HOT 1
- Add license
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from evil-goggles.