Queries generator inference error query instead queryRequiredSingle about edgedb-js HOT 7 CLOSED

Yes it's correctly typed but typescript complains

from edgedb-js.

Thanks for the report! We've been iterating on these, so I'll make sure we have test coverage here once we get it fixed.

from edgedb-js.

Looks like this is a misalignment of canary versions of the driver (which defines the introspection queries) and the generate module. See if you can update to the latest canary on both the driver package (edgedb) and the generator package (@edgedb/generate) and get it working. I've added some tests in a separate PR that ensures we don't break this again in the future.

from edgedb-js.

This is working as intended since that query does not throw if it doesn't find an object with that ID, it returns null instead. If you want the query to fail with a database error you could wrap that query in an assert_exists which will cause the query cardinality to be exactly one, which seems like the behavior you are expecting here.

from edgedb-js.

Oh actually the cardinality seems like it is wrong in your example, it should be using querySingle. Are you sure the query you are testing is filtering on exclusive property like in your example code above?

from edgedb-js.

Oh actually the cardinality seems like it is wrong in your example, it should be using querySingle. Are you sure the query you are testing is filtering on exclusive property like in your example code above?

Yes, I had a complex query before but then I also tested with this simple one. it was working fine before I upgraded to canary from the latest version 0.4.1

from edgedb-js.

Is your TestReturns type correctly typed as | null? When I run this on master, I get the following:

export type ExclusiveArgs = Readonly<{
  "id": string;
}>;

export type ExclusiveReturns = {
  "name": string;
  "id": string;
  "number_of_movies": number | null;
  "secret_identity": string | null;
  "height": string | null;
} | null;

export function exclusive(client: Executor, args: ExclusiveArgs): Promise<ExclusiveReturns> {
  return client.query(`\
select Hero {*} filter .id = <uuid>$id;`, args);

}

Which is correct for the types, although it isn't using querySingle (I'll look into that).

from edgedb-js.