Comments (1)
Yeah, agree about decoding into native types, as we can potentially validate the data even before it gets into the controller.
Validation is happening on the Go side thanks to Marshall and Unmarshall requirement of having to define these json structures as go types.
I also agree that we can use pure PHP for this, and gain a few neat features such as data types and expected values validation, a better structured codebase and thus cleaner code, and way less confusion on the controller side.
My suggestion is that we create the types and a class for serializing and deserializing these types from and to json. Then we replace the current option calls in the codebase with the native types ones which return known structures to PHP. Will be fun 😉
I see a good potential improvement here. Let's open a new issue based on this as the scope of doing it is probably gonna touch more parts of the codebase.
Originally posted by @paulotruta in #34 (comment)
from api.
Related Issues (14)
- Unit tests for the project
- [BUG] Don't show external connectivity settings when it is not possible to do a tunnel
- [DEV] Create partial twig templates for reusable parts
- [FEATURE] Support Task: Restart edgeboxctl / edgebox
- [DEV] TaskFactory folder location fix HOT 1
- [FEATURE] Settings Screen: Basic Info form + toggles
- [FEATURE] Storage Module Basis
- [BUG] Catch HTTP errors when communicating with API (open settings screen)
- [BUG] Uncaught Exception when logging in to edgebox.io in settings screen HOT 2
- [FEATURE] Cloud version should ask for edgebox.io credentials on first login, get jwt and login
- [FEATURE] Reactive transitions on edgeapps HOT 3
- setup.edgebox.local (Base tasks database structure, task execution request and status check, setup page, 1-click external access setup) HOT 1
- Leverage https://github.com/myaghobi/f3-migrations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api.