Comments (5)
edeso
commented on July 18, 2024
hmm have to dig in.
i know there is no upscaling in the app.
downscaling is done by subsampling (halfing resolution) until it fit's memory limit. will need to look into the implementation for details.
why do you ask? any issues?
from bubble2.
srappan
commented on July 18, 2024
A lot of downscaling methods can cause unwanted artifacts and make the image worse. (Added ringing, haloing)
I would recommend looking into image scalers.
Imagemagick has extensive information
https://www.imagemagick.org/Usage/filter/#hermite
Mitchell is usually recommended over Hermite for manga and comics to preserve screen tones, so I would recommend Mitchell as default downscaling kernel.
If you could link the bit of code that does scaling, I can possibly advise further.
12 Apr 2024 11:33:03 edeso ***@***.***>:
…
hmm have to dig in.
i know there is no upscaling in the app.
downscaling is done by subsampling (halfing resolution) until it fit's memory limit. will need to look into the implementation for details.
why do you ask? any issues?
—
Reply to this email directly, view it on GitHub[#13 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AGM2TO6EYJK52S323S3TGYTY46Z57AVCNFSM6AAAAABGD4HRI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRGUYDANRXHE].
You are receiving this because you authored the thread.
[Tracking image][https://github.com/notifications/beacon/AGM2TO6CC36EGITWCXV4Z5LY46Z57A5CNFSM6AAAAABGD4HRI2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT2I5VIO.gif]
from bubble2.
edeso
commented on July 18, 2024
feel free to dig in. would have to search myself. been a while since i touched that code.
and again
- i am not aware of any up-/downscaling in the app, except the subsampling during load which is not tunable in any way.
- i am not aware of artifacts introduced due to any type of resampling from the app. if you find any i my be persuaded to investigate
from bubble2.
srappan
commented on July 18, 2024
Are you using this library per chance?
If so, tachiyomi used it too and you can see the visual difference in the comparison to lanczos used by perfectviewer below.
https://slow.pics/c/Ak1KHcAS
12 Apr 2024 11:52:24 edeso ***@***.***>:
…
feel free to dig in. would have to search myself. been a while since i touched that code.
and again
1. i am not aware of any up-/downscaling in the app, except the subsampling during load which is not tunable in any way.
2. i am not aware of artifacts introduced due to any type of resampling from the app. if you find any i my be persuaded to investigate
—
Reply to this email directly, view it on GitHub[#13 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AGM2TO7J26ICV7FPUH6HIK3Y464GPAVCNFSM6AAAAABGD4HRI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRGUZDQOJYGM].
You are receiving this because you authored the thread.
[Tracking image][https://github.com/notifications/beacon/AGM2TO5GS7IGG6PJWDE43SDY464GPA5CNFSM6AAAAABGD4HRI2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT2I7MRO.gif]
from bubble2.
edeso
commented on July 18, 2024
again, there is no scaling in Bubble2 . there is merely subsampling, did you try it? do you see artifacts? please provide screenshots.
of course there is scaling by the display driver (usually OpenGL), but that is outside of the app scope as well. a common issue is a Moire Pattern and only fixable by costly realtime image manipulation according to scale/display/image-resolution.
any way. please provide artifacts created by Bubble2 in your comics/mangas. if there are none i see nor reason dive in any further.
there are loose plans to integrate smoeting along the lines of https://github.com/davemorrissey/subsampling-scale-image-view in the future. but there is no urgency as of now.
from bubble2.
Related Issues (14)
- Feature request: "night mode" HOT 3
- Feature request: side-by-side view HOT 1
- Show table of content HOT 6
- Add option to disable paging by touch (not swipe) HOT 7
- Crash in android 6 while opening file HOT 8
- Add scroll mode (Like webtoon) HOT 1
- Automatically open next file after reading current one file HOT 1
- show how much page is remaining while reading HOT 10
- Add option to read cbz file from password protected folder HOT 4
- Add option to read cbz file from 7z or zip file without extracting HOT 5
- Add option to select scrolling mode instead of swiping mode HOT 1
- Directories in library HOT 1
- Add option to search words in PDF HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bubble2.