Code Monkey home page Code Monkey logo

Comments (7)

edenhill avatar edenhill commented on August 15, 2024

Try the 0.6 branch.

My rudimentary tests show that it works with kafka-0.6

from librdkafka.

edenhill avatar edenhill commented on August 15, 2024

This commit fixes it:
bb9dbd3

from librdkafka.

eugpermar avatar eugpermar commented on August 15, 2024

Thanks Edenhill.
I have another question: The patch removes compression support, If we remove the compression field, librdkafka will remain compatible with kafka 0.7? Could we just put an if(), or maybe a preprocessor if, before the changes made in the bb9dbd3 to support both versions? (I don't care do it by myself)

By the way, I'm using librdkafka under C++, and I'm using a small wrapper to use it in a more POO way (it's just a header file for now) and I'd like to contribute with the project. Are you interested in include this file to provide a C++ interface?

Thanks and regards

from librdkafka.

edenhill avatar edenhill commented on August 15, 2024

From what I understand message compression was added in 0.7, so it is not available in the 0.6 protocol.

It would be possible to modify the code to support both 0.6 and 0.7, but I'm not sure if it is worth the effort.
Most people are on 0.7, and 0.8 will be released in less than a month and thats where development efforts should be put. 0.6 is dated, soon two years old.

Do you need 0.6 and 0.7 support in the same application, simultanously? Otherwise you could link rdkafka statically and provide two versions of your application, one for 0.6 and for 0.7, disregarding how impractical that sounds.

from librdkafka.

edenhill avatar edenhill commented on August 15, 2024

Re: C++

I'd be happy to receive a pull request providing a C++ interface!

from librdkafka.

edenhill avatar edenhill commented on August 15, 2024

Please close this issue if the 0.6 branch fix solves your original issue.

from librdkafka.

eugpermar avatar eugpermar commented on August 15, 2024

Do you need 0.6 and 0.7 support in the same application, simultanously?
No I don't. In fact, kafka 0.6 support it's just transitional. We are migrating v0.6 to v0.7 bit by bit, and I just wondering it there is a easy way to do this. The commit is more than sufficient, Thanks!

I will close the issue and send you the pull request.

from librdkafka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.