@adityaraute can u tell me how to review the code of other people??
like u do...

If you go to a PR and then check the files, you can spot the changes since GitHub highlights them as red and green, if you feel the changes are good then there's a review button above, you can click on it and approve the changes but if you are not satisfied with the changes and want to suggest then you will find plus icon in starting of each line, click it and you can comment there asking them to change and submit the review when you're done with commenting by choosing suggest changes or comment option in review button

from hacktoberfest-practice.

Think this is a good idea. May we can change from "initial commit" to "add your-github-username". What about using conventional commit messages with prefix fix: so new contributors learn about this standard. Maybe referring to www.conventionalcommits.org

from hacktoberfest-practice.

Think this is a good idea. May we can change from "initial commit" to "add your-github-username". What about using conventional commit messages with prefix fix: so new contributors learn about this standard. Maybe referring to www.conventionalcommits.org

Sounds good!

from hacktoberfest-practice.

Okk got it, Thanks... 🙂 @starlightknown

from hacktoberfest-practice.

It's great having you contribute to this project

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source, little and often 🤓 . Any questions let us know.

from hacktoberfest-practice.

Using fix: might not be a good idea here, because this is not really a fix. It is indeed their initial commit.

Perhaps something like First commit by <enter-username-here> might be a good way?

from hacktoberfest-practice.

Using fix: would definitely help new contributors as they would get an idea how things actually work,that is before creating a pull request,if an issue is been created and then in pull request if the fix is being referred (to that issue) that would be a good practice for the ones who are new to open source.

from hacktoberfest-practice.

Using fix: might not be a good idea here, because this is not really a fix. It is indeed their initial commit.

Yeah think you are right. Due it's poabably for all Contributer adding there name here their first contribution we should avoid overwhelming them with conventional commits (I've mentioned before).

from hacktoberfest-practice.

Is there anyone who is working on this or done with this issue??

from hacktoberfest-practice.

I don't see any PR. Wait till tonight, for an update else maybe start working on it. Won't be a big change.

from hacktoberfest-practice.

should I make a PR for this issue??
like fixes issue-no @adityaraute

from hacktoberfest-practice.

Yes proceed with it.

from hacktoberfest-practice.

@adityaraute, review PR #343

from hacktoberfest-practice.

I did, but it is of no relevance here. If you want to try solving this issue, try to create a new Pull Request.

from hacktoberfest-practice.

@adityaraute can u tell me how to review the code of other people??
like u do...

from hacktoberfest-practice.

closed by #343 acd7683

from hacktoberfest-practice.