Code Monkey home page Code Monkey logo

Comments (25)

eddiejaoude avatar eddiejaoude commented on August 11, 2024 1

Thanks for raising @dumbcoder7 👍 and sorry for the confusion.

Thanks @Vyvy-vi for replying. There is a fix for this now available by GitHub, I think we need to change the config a little bit to benefit from it

from hacktoberfest-practice.

adityaraute avatar adityaraute commented on August 11, 2024 1

I'm going to reopen this issue, cuz the issue still persists.

from hacktoberfest-practice.

github-actions avatar github-actions commented on August 11, 2024

It's great having you contribute to this project

Feel free to raise an Issue! Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

from hacktoberfest-practice.

Vyvy-vi avatar Vyvy-vi commented on August 11, 2024

Oh there's an open issue for this...
#342
#25
The workflow has a slight error. It doesn't work for forks, since they lack access to the repo's secrets
Don't worry about the statistics workflow failure 👍 as long as the build and lint workflow works(until the statistics workflow is configured)

from hacktoberfest-practice.

adityaraute avatar adityaraute commented on August 11, 2024

Okay, thanks.

from hacktoberfest-practice.

Vyvy-vi avatar Vyvy-vi commented on August 11, 2024

potential fix: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories

from hacktoberfest-practice.

eddiejaoude avatar eddiejaoude commented on August 11, 2024

@Vyvy-vi yes I think you are right 👍 . Let's try it 🤓

from hacktoberfest-practice.

eddiejaoude avatar eddiejaoude commented on August 11, 2024

thanks @adityaraute 👍

from hacktoberfest-practice.

adityaraute avatar adityaraute commented on August 11, 2024

Somebody please solve this. I am not skilled in this area sadly.

@Vyvy-vi did you try your fix, pal?

from hacktoberfest-practice.

Vyvy-vi avatar Vyvy-vi commented on August 11, 2024

I'll look into it 👍

from hacktoberfest-practice.

Vyvy-vi avatar Vyvy-vi commented on August 11, 2024

https://github.community/t/make-secrets-available-to-builds-of-forks/16166
https://github.community/t/allow-secrets-to-be-shared-with-forks-from-trusted-actions/16525

from hacktoberfest-practice.

Vyvy-vi avatar Vyvy-vi commented on August 11, 2024

Looks like a github issue

from hacktoberfest-practice.

adityaraute avatar adityaraute commented on August 11, 2024

But if GITHUB_TOKEN secret does not raise errors, why does this one do?

from hacktoberfest-practice.

Vyvy-vi avatar Vyvy-vi commented on August 11, 2024

FIREBASE_KEY

from hacktoberfest-practice.

Vyvy-vi avatar Vyvy-vi commented on August 11, 2024

The forked repo doesn't have the secret containing firebase key

from hacktoberfest-practice.

eddiejaoude avatar eddiejaoude commented on August 11, 2024

I think it would be best to not have the action run on forks, let me try a fix now

from hacktoberfest-practice.

eddiejaoude avatar eddiejaoude commented on August 11, 2024

Can you try to update your fork and now the GitHub Action should not run for the fork

from hacktoberfest-practice.

eddiejaoude avatar eddiejaoude commented on August 11, 2024

if this works, this condition should be added to all our community repos

from hacktoberfest-practice.

adityaraute avatar adityaraute commented on August 11, 2024

Do I just review a PR like I have did here?

from hacktoberfest-practice.

adityaraute avatar adityaraute commented on August 11, 2024

image
I reviewed a PR on this repo ( #297 ) error still persists.

from hacktoberfest-practice.

eddiejaoude avatar eddiejaoude commented on August 11, 2024

Was the fork updated with the latest code changes?

from hacktoberfest-practice.

adityaraute avatar adityaraute commented on August 11, 2024

Perhaps not. I am confused.

from hacktoberfest-practice.

eddiejaoude avatar eddiejaoude commented on August 11, 2024

We can see if anyone else reports it

from hacktoberfest-practice.

Vyvy-vi avatar Vyvy-vi commented on August 11, 2024

I think there was a second discussion for this and there was a consensus on stopping the community action, if running on forks

from hacktoberfest-practice.

github-actions avatar github-actions commented on August 11, 2024

Stale issue message

from hacktoberfest-practice.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.