Code Monkey home page Code Monkey logo

Comments (13)

ChinmayMhatre avatar ChinmayMhatre commented on September 23, 2024 1

@dhruvabhat24 I believe it is visible now. But I'll open the repo for conversation to check if this delay is happening to more people. We can have a discussion on this issue is persists!

from biodrop.

eddiejaoude avatar eddiejaoude commented on September 23, 2024 1

A new issue can be raised if it happens again, and we can then prioritise it again - but it seemed like it was a one off 🤞

ℹī¸ eddiejaoude has some opened assigned issues: 🔧View assigned issues

from biodrop.

eddiejaoude avatar eddiejaoude commented on September 23, 2024 1

Yes, testimonials are reloaded when the app is deployed, you can see the code here https://github.com/EddieHubCommunity/BioDrop/blob/main/.github/workflows/vercel.yml#L55

From the deploy GitHub Action there has been no deployments for 3 days https://github.com/EddieHubCommunity/BioDrop/actions/workflows/vercel.yml

I think the code to load the testimonials should be moved from the deploy app to the testimonials GH Action

run: curl -L -f https://biodrop.io/api/system/testimonials-forms?secret=${{ secrets.BIODROP_API_SECRET }}

from biodrop.

github-actions avatar github-actions commented on September 23, 2024

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

from biodrop.

dhruvabhat24 avatar dhruvabhat24 commented on September 23, 2024

Yes now it is visible. I think it's better to make an announcement that if anyone is facing the same issue then they can discuss here

from biodrop.

dhruvabhat24 avatar dhruvabhat24 commented on September 23, 2024

@eddiejaoude I have received one more testimonial and facing the same issue as earlier. sorry for raising the same issue again and again.

from biodrop.

eddiejaoude avatar eddiejaoude commented on September 23, 2024

No problem, but it has only been 1 hour since the testimonial - please can we give it time to see if the standard workflow works

ℹī¸ eddiejaoude has some opened assigned issues: 🔧View assigned issues

from biodrop.

dhruvabhat24 avatar dhruvabhat24 commented on September 23, 2024

@eddiejaoude okay

from biodrop.

dhruvabhat24 avatar dhruvabhat24 commented on September 23, 2024

It's been more than 48 hours and it didn't fetch

from biodrop.

eddiejaoude avatar eddiejaoude commented on September 23, 2024

I have manually reloaded testimonials, please check your account now

ℹī¸ eddiejaoude has some opened assigned issues: 🔧View assigned issues

from biodrop.

dhruvabhat24 avatar dhruvabhat24 commented on September 23, 2024

I have checked now but still it is displayed on account I think you need to make the testimonial sections to GitHub actions

from biodrop.

github-actions avatar github-actions commented on September 23, 2024

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

from biodrop.

ArvindParekh avatar ArvindParekh commented on September 23, 2024

Hi! I'd like to help with this. Although I do not know about GH Actions (yet), I'm willing to learn on the go. I read about it and here's what I think needs to be done:

  • At present, the code to reload the testimonials lies in the vercel.yml file, where testimonials are only reloaded when the load-data job runs, which depends on the deploy workflow.
  • So I should figure out a way to update the testimonials without needing the deploy job to run.

Am I correct? Also, do I have to make changes to the testimonial.yml or just to vercel.yml?

from biodrop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.