The special modules aren't displayed into the data sent to Eddn about edmarketconnector HOT 21 CLOSED

They should be, see here:
https://github.com/Marginal/EDMarketConnector/blob/master/outfitting.py#L211

from edmarketconnector.

yep, i saw them... but in Eddn there are no "Prismatic Shield Generator" into data logs

from edmarketconnector.

I don't have them in database, have you seen them in game?

from edmarketconnector.

According to EDDB, lot of prismatic have been received.

from edmarketconnector.

yep
At the "Jormor" system into "Cardano Port" i harvested the outfiting's datas by edce_client.py that gives me original datas from "companion app"

a prismatic shield is displayed like this:
'128671323': {
'id': 128671323,
'cost': 132200,
'category': 'powerplay',
'name': 'Int_ShieldGenerator_Size1_Class5_Strong',
'sku': 'ELITE_SPECIFIC_V_POWER_100000'
},

these datas are correctly managed by EDMC as you showed me, but this data doesn't arrive at Eddn correctly or... Eddn changes its name... dunno.

the result is that there are no update regarding prismatic shield for those apps that get data from eddn

The difference between normal and special modules should be just into the name of the module, this doesn't affect the schema validation working

from edmarketconnector.

Well EDDN don't change anything on the received JSON.

But EDMC should send something like that:

{
    "category": "internal",
    "rating": "A",
    "name": "Prismatic Shield Generator",
    "class": "2"
}

from edmarketconnector.

PP-specific modules and other modules that depend on the player's purchases, rank or affiliation are only visible to you in-game and in the data returned from the Companion API if you are eligible for the module.

This presents a problem for EDDN because it makes the data unstable - a commander will send a list of modules for a station and then a minute later another commander will send a different list. So the schema says that such modules should be omitted - which is what EDMC does.

In practice, I believe that PP-specific modules are always available (to those who are eligible) when the "base" version of the module is available. I think that's the logic that EDDB is using.

Edit:

They should be, see here:
https://github.com/Marginal/EDMarketConnector/blob/master/outfitting.py#L211

The reason for this is for exporting the player's ship loadout in E:D Shipyard or Coriolis format.

from edmarketconnector.

So my bad ;)
I should add them to my database :D

from edmarketconnector.

looking into these logs : https://ross.eddb.io/eddn/log

there's no reference to any prismatic shield at any station :\

from edmarketconnector.

i'm wondering if this kind of issue affects all "special" modules.

from edmarketconnector.

at Cardano Port - Jormor there are:

specials shield:
size | class
1 | 5
2 | 5
3 | 5
4 | 5
5 | 5
6 | 5
7 | 5
8 | 5

normal shield:
from size 2 to size 6 and just size 2 and 3 have class 5.

In this case the normal modules availability doesn't reflect the availability of special modules.

They could be simply marked as "powerplay_modules" = 1, like the "mount" and "guidance" parameters, and when the server checks for duplicated sent datas to prevent spam, it could simply ignore those modules.

Or better... they could be sent as "powerplay_outfitting" like at the moment are "modules", "ships" and "commodities"

from edmarketconnector.

In this case the normal modules availability doesn't reflect the availability of special modules.

I've also read on the forums that they're all available at stations that supply outfitting, which your findings seem to confirm. Can you try some other stations?

They could be simply marked as "powerplay_modules" = 1

That doesn't help with the data instability issue. The outfitting message is supposed to indicate all modules that are currently available at a station (because modules can go out of stock). Under this idea, if a player's outfitting message doesn't include Prismatic Shields what does this indicate about whether the station sells them?

from edmarketconnector.

FYI the wiki says "As soon as the player unlocks the Prismatic Shield Generator all large stations (even in hostile systems) will sell it for all module-classes from A1 - A8.[citation needed]".

Also, this post says that "Powerplay modules should now only be available in systems controlled by the power in question". But Jormor/Cardano Port isn't controlled by Aisling so that's not true.

Can you fly around and try a few other stations?

from edmarketconnector.

I meant simply that they could be managed as 4th batch of data ( like "commodities", "modules" or "ships" are ) if the player has the possibility to send those datas...

This shouldn't affect eddn stability but simply has to implement that 4th schema... that it will be quite identical to "modules"

from edmarketconnector.

I meant simply that they could be managed as 4th batch of data ( like "commodities", "modules" or "ships" are ) if the player has the possibility to send those datas...

If the wiki is correct then these messages would be redundant.

from edmarketconnector.

yep, like the ships availability is, till new ships are implemented by Frontiers.

Anyway i'll check the correctness of that rule in the wiki, also if it's valid for other power play modules

EDIT: i can't because i don't wanna change my pledge in game.... :(

from edmarketconnector.

Looking at my logs from July it seems that my PP-specific weapon was available:

• in systems controlled, systems not controlled, and systems not exploited by my Power
• at a least one station where the "base" module was not available

And I didn't find any stations that supplied outfitting but that didn't stock my PP-specific weapon.

So from my limited sample it looks to me that PP-specific modules are available (to those who are eligible) at any station that supplies outfitting. Unless things have changed since then.

from edmarketconnector.

In controlled or not controlled?

from edmarketconnector.

At the moment:

• the larger update is about 8 modules for prismatic shields
• those data are available from "companion's api"
• Frontiers stated that they can change or add content live
• every tools add those powerplay modules supposing that the rule for prismatic shields still be valid for all power play modules, this hoping that rule still be valid since the date that info was inserted and that Frontiers doesn't change it live.

from edmarketconnector.

In controlled or not controlled?

Both. I've edited that comment.

those data are available from "companion's api"

Only to those players who are eligible for the module, which is a small percentage of the player base. So the data will be very incomplete.

If PP-specific modules become hard to find in the future then this might be worth contemplating, but right now it seems pointless and counter-productive to me.

from edmarketconnector.

so be it, thank you for your patience on replying to me ;)

from edmarketconnector.