Version: 5.10.1+5419e2e Game Version: Odyssey OS: Win11 <

In the past an empty string for stockBracket or <code

companion.fixup:1226: Invalid stockBracket: (<class 'str'>) for Tritium,about edcd/edmarketconnector

Comments (3)

bgol commented on July 4, 2024

companion points to the CAPI response which you can save as file with File -> Save raw data it would be the /market entry.

from edmarketconnector.

klightspeed commented on July 4, 2024

In the past an empty string for stockBracket or demandBracket has meant that the commodity is not normally traded at a station

EDMarketConnector/companion.py

Lines 1217 to 1229 in 5419e2e

    
           for commodity in data['lastStarport'].get('commodities') or []: 
        
               # Check all required numeric fields are present and are numeric 
        
               # Catches "demandBracket": "" for some phantom commodites in 
        
               # ED 1.3 - https://github.com/Marginal/EDMarketConnector/issues/2 
        
               # 
        
               # But also see https://github.com/Marginal/EDMarketConnector/issues/32 
        
               for thing in ('buyPrice', 'sellPrice', 'demand', 'demandBracket', 'stock', 'stockBracket'): 
        
                   if not isinstance(commodity.get(thing), numbers.Number): 
        
                       logger.debug(f'Invalid {thing}:{commodity.get(thing)} ({type(commodity.get(thing))}) for {commodity.get("name", "")}')  # noqa: E501 
        
                       break 
        
               else:

I wonder if in this case stockBracket is an empty string because the carrier accepts tritium as fuel?

from edmarketconnector.

Rixxan commented on July 4, 2024

Hmm, I'm having issues validating this report. Can you break down more details as to how this issue presents itself? Is it when the carrier has a buy order? sell order? Something else?

More information on how to replicate this would be greatly appreciated.

from edmarketconnector.

Recommend Projects

companion.fixup:1226: Invalid stockBracket: (<class 'str'>) for Tritium about edmarketconnector HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	for commodity in data['lastStarport'].get('commodities') or []:

	# Check all required numeric fields are present and are numeric
	# Catches "demandBracket": "" for some phantom commodites in
	# ED 1.3 - https://github.com/Marginal/EDMarketConnector/issues/2
	#
	# But also see https://github.com/Marginal/EDMarketConnector/issues/32
	for thing in ('buyPrice', 'sellPrice', 'demand', 'demandBracket', 'stock', 'stockBracket'):
	if not isinstance(commodity.get(thing), numbers.Number):
	logger.debug(f'Invalid {thing}:{commodity.get(thing)} ({type(commodity.get(thing))}) for {commodity.get("name", "")}') # noqa: E501
	break

	else: