Comments (5)
It seems like it would be fairly simple to require that clients check that Analyse
scans have the same SystemAddress
and Body
as a prior scan for the same Genus
(as long as a prior values have been recorded during that play session). This may lead to some dropped Analyse
scans but we'd probably still be able to capture the majority of them.
Or am I misunderstanding the nature of the bug?
from eddn.
I'm not 100% sure. I should be able to find some examples or reproduce the issue. I'll do that today
from eddn.
Three scan events are generated.
Log -- First scan
Sample -- Second scan
Sample -- Third scan
Analyse -- After the burn animation
The analyse event is triggered when the animation completes. If the CMDR boards their ship before the animation is finished, then the event will wait until next time the Organic Scanner is activated and the animation completes, which could be the other side of the galaxy.
In all cases the BodyId and the SystemAddress have the correct location recorded in the event.
Only the anaylse event can occur on a different planet.
So the sender needs to make sure that if they enrich the record with Lat/Lon BodyName and SystemName that they match with the BodyId and SystemAddress on the event.
It may be simpler to not send analyse events as the lat/lon cannot be trusted, because the position could be anywhere on the same planet. Without identifiying information its not all that useful and the data will already have been recorded in the second Sample Event so nothing is lost by skipping it.
from eddn.
With that info, the "analyse" scantype appears to me to be superfluous data which can be safely omitted altogether as well.
from eddn.
Agreed
from eddn.
Related Issues (20)
- Ensure we can cope with feasible incoming `/upload/` rates HOT 4
- `ApproachSettlement` may refer to entities without MarketID HOT 6
- ApproachSettlement: Horizons bug might cause no Latitude/Longitude HOT 1
- Schema: fssbodysignals/1 HOT 5
- Augmentations: Document necessary cross-checks
- POST support interfering with `fsssignaldiscovered/1` schema HOT 2
- schemas: Add for `FCMaterials` data HOT 14
- Status page could perhaps use a link to the github
- All schemas: Consider making `horizons` and `odyssey` flags mandatory
- All schemas: New `gameversion` *header* field HOT 9
- schemas: Review all to ensure *schema* defines things as correctly as possible.
- Schemas/gameversion: Document denoting Live versus Legacy for CAPI data HOT 10
- Relay: Add logging of when a duplicate is dropped
- fcmaterials_journal-v1.0.json is missing items property from array HOT 1
- monitor: Add stats/table for gameversion
- shipyard-v2.0.json missing event field in message object HOT 1
- Request - Add event CommunityGoal
- Gateway: Log a message->message hash, and put it in message->header
- Investigate verifying EDDN Senders HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eddn.