Code Monkey home page Code Monkey logo

Comments (3)

BGerwe avatar BGerwe commented on May 29, 2024 2

Adding this element seems fine to me, I've never heard of this element being used but I don't see any harm in adding it to our list. Before submitting the PR please add a citation to the doc string for the academic article used in the application note, if there is one. I think the element name should either follow what's in the application note (La), or Lf to follow the naming convention used by Bernard Boukamp for fractal elements (which I'm guessing is part of the derivation for this element). Other than that, just look at how other elements are implemented and follow those conventions.

And, yeah, please add tests for the element, we just hit 100% coverage yesterday and we're hoping to keep it there 😃

from impedance.py.

hkennyv avatar hkennyv commented on May 29, 2024 2

wow gratz on 100% cov! i can work on this one and get a PR ready for review in the next couple days :)

from impedance.py.

dt-schwartz avatar dt-schwartz commented on May 29, 2024 1

The biologic application note has a couple of publications cited at the end. I have not looked at them, but if they have the correct form of modified inductance and show the high & low frequency behaviors, you may want to cite those since they have DOIs and are long-lived archived docs.

from impedance.py.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.