climetlab should not require branca==0.3.1 about climetlab HOT 5 CLOSED

I saw you removed the exact dependency to branca 0.3.1 in release 0.13.5.
Thanks, this issue can be closed.

from climetlab.

Yes, I guess the setup.py could then be updated to branca<=0.3.1,branca>=...
Do you want to submit a PR?

from climetlab.

It's difficult for me to submit a PR because :

• I don't know what is exactly climetlab problem with branca>0.3.1, I only know that the branca issue is referenced in setup.py
• the branca issue is closed not because of a change in branca, but because of a new folium support in streamlit with streamlit-folium library (see python-visualization/branca#81 (comment))

So I don't know if the climetlab problem (I guess it has something to do with folium, which by the way is an optional dependency) would be resolved by changing branca dependency, or changing folium dependency, or adding streamlit-folium dependency...

If you give me the scenario to reproduce the problem, I could make some tests and maybe then submit a PR.

My problem is that a would like to use climetlab and other packages requiring branca>0.3.1 in the same python program...

from climetlab.

This was introduced to make sure this notebook works, for interactive maps: https://climetlab.readthedocs.io/en/latest/examples/17-interactive-maps.html
This notebook is expected to work when we install pip install climetlab[interactive]

At this time we had to install the dependencies "skinnywms" and "folium>=0.12.1" (see in the setup.py, the extra "interactive").
Since it causes weird dependency problems with branca versions and the most robust solution were to set branca>0.3.1.

I suggest using this notebook as a test (there are no test on this interactive map, this is a very experimental feature). If it still works, as long as the other tests, we are good to go.

from climetlab.

Sorry, I don't have the time nor the competencies (not a folium user) to work on this...
I just think it's not a good thing to have a 5 years old dependency in climetlab and that you should find a way to update it.
May be changes in _folium.py would be necessary to achieve that.

Until then, may be branca==0.3.1 could only be an extra "interactive" dependency ?

from climetlab.