Code Monkey home page Code Monkey logo

Comments (17)

Vadorequest avatar Vadorequest commented on August 20, 2024 1

@ecmadao PR done! (english only yet, I'll add FR when we're good with EN)

I looked at the website, almost everything is translated now, thanks!

I shared you website on Slack and I got a mix of English/Chinese in the preview mode:

image

I guess this part has been missed ;)

from hacknical.

Vadorequest avatar Vadorequest commented on August 20, 2024 1

Also, in the graphics there are some missing translation too :)

image

from hacknical.

ecmadao avatar ecmadao commented on August 20, 2024

@Vadorequest
Wow coooooooooooooool! I even didn't think of that before.
Actually, this website was designed for Chinese developers at first, but I'm also interested in supporting multiple languages. I'll work on that these days.
Thank you!

from hacknical.

ecmadao avatar ecmadao commented on August 20, 2024

Hey @Vadorequest
Glad to say that I have support a basic English version now 😁 --> http://hacknical.com
Atleast, github data analysis page totally support EN, and I'll working on resume page later.
Thanks again !

from hacknical.

Vadorequest avatar Vadorequest commented on August 20, 2024

from hacknical.

Vadorequest avatar Vadorequest commented on August 20, 2024

#23

from hacknical.

ecmadao avatar ecmadao commented on August 20, 2024

@Vadorequest
Pretty cool. I'm quite sure that I have few mistakes on translation, glad to see you are working on them. THX!

from hacknical.

ecmadao avatar ecmadao commented on August 20, 2024

@Vadorequest
Almost Done 😁
You can check and review now.

from hacknical.

Vadorequest avatar Vadorequest commented on August 20, 2024

@ecmadao FR version added + minor EN review

#32

from hacknical.

ecmadao avatar ecmadao commented on August 20, 2024

@Vadorequest

The bug of texts in chart has fixed now, and FR version is initialized now, cool!!! I'm really appreciate of your contributions.

However, if we wanna totally support FR, we also have to check locale files at frontend locales folder, then add new file names fr.js in each folder. Besides, you can find and check EN locale files there.

As for me, I will working on fetching orgs info for each user, and analyse users contributions for each forked & org repository.

from hacknical.

Vadorequest avatar Vadorequest commented on August 20, 2024

Cool! Yep, I've missed the frontend part ^^
I'll take a look ASAP :)

from hacknical.

Vadorequest avatar Vadorequest commented on August 20, 2024

@ecmadao I'll use files with the name fr.js and not fr-FR.js, following the same pattern as the en.js. Good for you?

from hacknical.

Vadorequest avatar Vadorequest commented on August 20, 2024

A few questions:

  • I wonder what you mean by PV?
  • I didn't understood until now that Resume Share Datas / GitHub Share Datas were "tabs" I thought they were just text, not links, maybe it should be made more obvious?
  • About the Platform and Browser, "Max Platform", don't you mean "Preferred platform" instead? I guess you can somehow figure out what's the platform/browser GitHub users use? I didn't know it was possible.

from hacknical.

Vadorequest avatar Vadorequest commented on August 20, 2024

@ecmadao New PR :)

#35

from hacknical.

Vadorequest avatar Vadorequest commented on August 20, 2024

But I think the english version must be reviewed by a chinese-english speaker first, it's not really easy to translate as it, and it feels like the choice of the words can be improved ;)

Note that the french version is not fully covered yet, sometimes I don't really how I should translate ^^

from hacknical.

ecmadao avatar ecmadao commented on August 20, 2024

@Vadorequest

Use fr.js instead of fr-FR.js is cool.😁

PV means Page view, and Max Platform is what you think, I record each visit to the shared link, and figure out most preferred platform visitors used. It's my fault to not translate it clearly.

Besides, thanks for your advance of Resume Share Datas / GitHub Share Datas tab, I'll find a better way to show them.
Soooo sorry for my pool English transition that bothered you.😵

from hacknical.

Vadorequest avatar Vadorequest commented on August 20, 2024

@ecmadao It's fine, don't worry ;) I took a look at your other repo and I also like the GitHub extension!
Besides, I sucked at English for so long... If we have had that discussion 5 years ago you'd have looked like Shakespeare to me! ^_^

from hacknical.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.