Issue with rendering validation errors for oneOf and anyOf about jsonforms HOT 6 CLOSED

Hi @alxdru , thanks for the report :)
I have two questions:

1. Which framework (e.g. react, angular, vue) and which renderer set did you use?
2. Could you try this with the latest released version 3.2.1 to see if that fixes the issue?

Thanks!

from jsonforms.

Hi @lucas-koehler

1. We're using react 18 and @jsonforms/material-renderers 3.1.0
2. I've tried both 3.2.0 and 3.2.1, unfortunately no positive results.

from jsonforms.

We are still having this issue.
@lucas-koehler Have you reproduced the issue by any chance?

from jsonforms.

Hi @alxdru , I have tested this now in the react seed and I could reproduce the issue. I also contrasted the oneOf with a simple string property outside the oneOf and there a validation error was still shown even with validation mode NoValidation.

For reference for future investigations. I used the following in the jsonforms react seed with jsonforms 3.2.1

{
  "type": "object",
  "properties": {
    "addressOrUser": {
      "oneOf": [
        {
          "type": "object",
          "title": "Address",
          "properties": {
            "street_address": { "type": "string" },
            "city": { "type": "string" }
          },
          "required": ["street_address", "city"]
        },
        {
          "type": "object",
          "title": "User",
          "properties": {
            "name": { "type": "string" },
            "mail": { "type": "string" }
          },
          "required": ["name", "mail"]
        }
      ]
    },
    "plain-prop": {
      "type": "string"
    }
  },
  "required": ["plain-prop"]
}

import Ajv, { ErrorObject } from 'ajv';

// [...]
const [additionalErrors, setAdditionalErrors] = useState<ErrorObject[] | undefined>([]);
const ajv = new Ajv();
const validator = ajv.compile(schema);

// [...]
<JsonForms
  schema={schema as any}
  // uischema={uischema}
  data={data}
  renderers={renderers}
  cells={materialCells}
  onChange={({ errors, data }) => {
    setData(data);
    validator(data);
    setAdditionalErrors(validator.errors ?? undefined);
  }}
  additionalErrors={additionalErrors}
  validationMode='NoValidation'
/>

from jsonforms.

Hi @alxdru ,
I had a look again and noticed that I forgot that we need the AJV options allErrors. You can use convenience method createAjv from @jsonforms/core to get an Ajv with required options preconfigured. Using this, the validation in the oneOf also worked with NoValidation.
Can you check whether that works for you?

from jsonforms.

Thanks @lucas-koehler , using the createAjv did the trick.

Prior to this I was indeed passing allErrors: true to the ajv constructor, but I guess there were some other properties missing as well.

from jsonforms.