[ASM] IncrementalBuilder with JavaLanguage does not work with Inner Classes about xtext-extras HOT 9 CLOSED

This is the Analysis of the Problem

• asm creates classes with uris like java:/Objects/org.eclipse.xtend.core.tests.build.Outer$Inner$InnerMost#org.eclipse.xtend.core.tests.build.Outer$Inner$InnerMost
• index entries look like org.eclipse.xtend.core.tests.build.Outer..Inner.InnerMost
• IndexedJvmTypeAccess uses the $URI to do the index lookup and will not find anything.

@szarnekow and i assume that we have to iterate over all possibilities there. (replacing $with .in all combinations.

@svenefftinge @JanKoehnlein what do you think.

from xtext-extras.

Provided a prototype impl and some test (here and at https://github.com/eclipse/xtext-xtend/tree/cd_extras_issue30

Feedback and input is welcome. At InnerClassNameVariants i currently have 2 impls that (should) do the same. i dont know which one i (dis)like more.

from xtext-extras.

feedback in welcome. all the rebasing drives me nuts

from xtext-extras.

Thx christian, for all the analysis. I think there is something wrong with how the java language contributes to the index, because this issue only seems to occur in that scenario.
I hope I can find time to look at this ASAP.

from xtext-extras.

i debugged that as well, the visit methods build the names this way

from xtext-extras.

i had a discussion with @szarnekow on that. he meant

wenn asm die klassen anschaut, ist nicht bekannt, ob ein nested class referneziert ist, oder ein top-level-class

thus i went the way to address this in the access

from xtext-extras.

Ok, in that case being more flexible with incoming names seems to be the best solution.
I like the stream-based approach a bit more.

from xtext-extras.

A PR would be awesome! :)

from xtext-extras.

Fixed in Xtext 2.11

from xtext-extras.