Code Monkey home page Code Monkey logo

Comments (11)

spoenemann avatar spoenemann commented on August 15, 2024

are testlangs not published to oss?

Of course not.

from xtext-extras.

cdietrich avatar cdietrich commented on August 15, 2024

but then building without -PuseJenkinsSnapshots=true makes no sense
cause it always will fail

from xtext-extras.

spoenemann avatar spoenemann commented on August 15, 2024

Can we eliminate that dependency?

from xtext-extras.

cdietrich avatar cdietrich commented on August 15, 2024

i think only by copy and pasting the testlangs

from xtext-extras.

spoenemann avatar spoenemann commented on August 15, 2024

Then that's what we would need to do to solve this issue.

Test languages are part of the tests and thus should not be made public. These inter-repository test dependencies are a leftover of the pre-splitting repository state and indicate that the repositories are not as self-contained as they should be.

from xtext-extras.

cdietrich avatar cdietrich commented on August 15, 2024

well that would basically mean to copy the test languages to all modules. thus i am wondering if we need to bootstrap the test languages

from xtext-extras.

svenefftinge avatar svenefftinge commented on August 15, 2024

I've removed the deps to org.eclipse.xtext:org.eclipse.xtext.testlanguages in all modules from extras and haven't seen any issues (no compile errors nor test failures).
Am I missing something? Are they used downstream?

from xtext-extras.

svenefftinge avatar svenefftinge commented on August 15, 2024

IF there are dependencies we should look at them and decide if those tests are worth publishing testlanguages or if copying them over would be more beneficial. Generally it is better to have the test data close to the tests.

from xtext-extras.

cdietrich avatar cdietrich commented on August 15, 2024

i get compile errors on your branch

/data/xtext-master/git/xtext-extras/org.eclipse.xtext.common.types.tests/tests/org/eclipse/xtext/common/types/access/impl/IndexedJvmTypeAccessTest.java:17: error: package org.eclipse.core.internal.resources does not exist
import org.eclipse.core.internal.resources.ProjectDescription;
                                          ^
/data/xtext-master/git/xtext-extras/org.eclipse.xtext.common.types.tests/tests/org/eclipse/xtext/common/types/access/impl/IndexedJvmTypeAccessTest.java:56: error: cannot find symbol
                ProjectDescription projectDescription = new ProjectDescription();
                ^
  symbol:   class ProjectDescription
  location: class IndexedJvmTypeAccessTest
/data/xtext-master/git/xtext-extras/org.eclipse.xtext.common.types.tests/tests/org/eclipse/xtext/common/types/access/impl/IndexedJvmTypeAccessTest.java:56: error: cannot find symbol
                ProjectDescription projectDescription = new ProjectDescription();
                                                            ^
  symbol:   class ProjectDescription
  location: class IndexedJvmTypeAccessTest

from xtext-extras.

cdietrich avatar cdietrich commented on August 15, 2024

and when fixing this

java.lang.NoClassDefFoundError: Could not initialize class org.eclipse.emf.ecore.xml.namespace.XMLNamespacePackage
	at org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.addNamespaceDeclarations(XMLSaveImpl.java:900)
	at org.eclipse.emf.ecore.xmi.impl.XMISaveImpl.addNamespaceDeclarations(XMISaveImpl.java:164)
	at org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.traverse(XMLSaveImpl.java:607)
	at org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.save(XMLSaveImpl.java:251)
	at org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.doSave(XMLResourceImpl.java:389)
	at org.eclipse.emf.ecore.resource.impl.ResourceImpl.save(ResourceImpl.java:1430)
	at org.eclipse.xtext.resource.uriHell.AbstractURIHandlerTest.getBytes(AbstractURIHandlerTest.java:101)
	at org.eclipse.xtext.resource.uriHell.AbstractURIHandlerTest.doTest(AbstractURIHandlerTest.java:122)
	at org.eclipse.xtext.resource.uriHell.AbstractURIHandlerTest.testLoadResourceWithPackagedURIs(AbstractURIHandlerTest.java:150)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.eclipse.xtext.testing.XtextRunner$1.evaluate(XtextRunner.java:49)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
	at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
	at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

(calling gradlew build without -PuseJenkinsSnapshot=true (as jenkins does)

from xtext-extras.

cdietrich avatar cdietrich commented on August 15, 2024

update to the last problem: i get it on master as well => different problem

from xtext-extras.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.