Code Monkey home page Code Monkey logo

Comments (5)

sbernard31 avatar sbernard31 commented on May 16, 2024

You're right, since the refactoring/API changing all about object links (register, update, discover) is in a pretty bad state.
I currently work on it.

from leshan.

sbernard31 avatar sbernard31 commented on May 16, 2024

So, I fixed the problem of link object which does not contains instance ID at registration.
I also integrated what you propose to fix the update problem.
But, This means now when you want to update the Link Object part you must write something like that ...

client.send(new UpdateRequest(
         "registrationId", null, null, null, 
         LinkFormatHelper.getClientDescription(client.getObjectEnablers(), null)));

not really sexy !
Maybe, it's not so bad, because we should probably manage update automatically. User should not have to write this kind of code ...

from leshan.

 avatar commented on May 16, 2024

Yes, may be we can improve this in the future...

from leshan.

ingoschaal avatar ingoschaal commented on May 16, 2024

The implementation of the visit method with UpdateRequest still contains this implementation:

LinkObject[] linkObjects = request.getObjectLinks();
if (linkObjects == null) 
coapRequest.setPayload(LinkObject.serialyse(linkObjects));

I think it should be implemented as described above

    if (linkObjects != null) {
        payload = LinkFormatUtils.payloadize(linkObjects);
        coapRequest.setPayload(payload);
    }

from leshan.

sbernard31 avatar sbernard31 commented on May 16, 2024

It was a bug. it should be fixed now.

from leshan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.