Possibility of getting into a read() operation even when the channel is not ready about grizzly HOT 10 CLOSED

• Issue Imported From: javaee/grizzly#42
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @glassfishrobot
• Original Issue Closed By:@glassfishrobot

from grizzly.

@glassfishrobot Commented
Reported by [email protected]

from grizzly.

@glassfishrobot Commented
[email protected] said:
Hi Harsha,

(since there is while loop) the event is not OP_READ but it's OP_WRITE.. the
program control goes "happily" to (D) and returns true from there. Which means
to delegate work to workere thread that's line:363(A) Now, Grizzly goes and
invokes the protocol chain and hence the read filter at the WRONG time.

I don't see any problem here. Whatever it is an OP_READ or OP_WRITE, the
ProtocolChain will always invoked. It is your (meaning the implementor) role to
make sure the ProtocolFilter you inject can both handler OP_READ and OP_WRITE.
Based on your description, it seems you inject the ReadFilter for handling
OP_WRITE, which is wrong.

What is needed (missing) is a ProtocolFilter that can handle both read and
write. Changing the bug to an RFE. Feel free to change it back if I didn't
understood the problem correclty.

from grizzly.

@glassfishrobot Commented
[email protected] said:
Certainly this is a nice addition for 1.8.0

from grizzly.

@glassfishrobot Commented
[email protected] said:
Target fix for 1.7.3

from grizzly.

@glassfishrobot Commented
[email protected] said:
Using currentOpType to distinguish whether the filter is being called for OP_WRITE or OP_WRITE would
work. But it would be good, if this is handled by framework itself.

There should be a way to add different Filters exclusively for OP_READ and OP_WRITE. Also current
ReadFilter can be enhanced so that it can be used even when a OP_WRITE is registered on the main
selector.

from grizzly.

@glassfishrobot Commented
[email protected] said:
The ReadFilter will now reject OP_WRITE:

https://grizzly.dev.java.net/issues/show_bug.cgi?id=146

Closing this as fixed.

from grizzly.

@glassfishrobot Commented
Was assigned to [email protected]

from grizzly.

@glassfishrobot Commented
This issue was imported from java.net JIRA GRIZZLY-42

from grizzly.

@glassfishrobot Commented
Marked as fixed on Wednesday, December 16th 2009, 6:14:11 pm

from grizzly.