Code Monkey home page Code Monkey logo

Comments (14)

centerax avatar centerax commented on June 2, 2024

Im not seeing such error. Tested again on the latest release and emails are sent out. Maybe its something else on your setup, another extension or something.

from magento2-mandrill.

Silarn avatar Silarn commented on June 2, 2024

We don't have any other extensions hooking into the mail system. It makes perfect sense to me. The current version instantiates the mandrill transport model but never passes the message data from the transport builder to the instantiated model. It then 'sends' the mail with no message being set.

Instead, you hook into transport factory 'create' method which sets that data and switcheroo the model being created (passing in the message data from the plugged-in function). You pretty much have to do it this way because the transport builder doesn't have publicly accessible data, only setters. When it creates the transport model, it passes the message data to the factory.

If it makes any difference, we're running Magento 2.1.6.

from magento2-mandrill.

centerax avatar centerax commented on June 2, 2024

can you post here some logs from your Mandrill API logs to see the message without content?

from magento2-mandrill.

lgrassini avatar lgrassini commented on June 2, 2024

Same here, Mails not being sent at all (not even the Test Email)...
The only API calls showing in the log are the /users/info.json.

I'm getting the following error: "No body specified".
Magento 2.1.6.

@centerax

from magento2-mandrill.

lgrassini avatar lgrassini commented on June 2, 2024

@Silarn Can you please elaborate how do you fixed this? I'm having exactly the same problem you reported. Thanks you!

from magento2-mandrill.

Silarn avatar Silarn commented on June 2, 2024

@centerax The message is never sent because there is no message data in the Transport model. There's no log to show you. I'll try to detail my fix in a second post.

from magento2-mandrill.

Silarn avatar Silarn commented on June 2, 2024

In my earlier post I opted to use a new module with a plugin as a fix rather than changing the module code.

The first portion was the contents of the Namespace_NewModule <module_dir>/etc/di.xml file.

The second portion is a file you need to create under <module_dir>/Plugin/Mail/TransportInterfaceFactory.php`.

In addition, you need a basic /etc/module.xml file, composer.json file, and registration.php file.

Here is a basic tutorial.

from magento2-mandrill.

centerax avatar centerax commented on June 2, 2024

@Silarn if the body is empty that should not prevent the message from being sent, you can send an empty email. But if you say there is no log on Mandill, thats ok.

from magento2-mandrill.

Silarn avatar Silarn commented on June 2, 2024

It's not the mail body. It's all of the message data. There is no data in the transport model so nothing is sent.

from magento2-mandrill.

centerax avatar centerax commented on June 2, 2024

I was not able to replicate this case. Testing on 2.1.7 at the moment without success to have an empty object

from magento2-mandrill.

lgrassini avatar lgrassini commented on June 2, 2024

Thank you @Silarn !
I was able to get my emails dispatched by applying @Silarn fix.
@centerax Please consider reviewing the implementation of the fix #30 is definitely breaking the magento2-mandrill extension.

from magento2-mandrill.

Silarn avatar Silarn commented on June 2, 2024

@lgrassini I've recently created a PR containing this change which they've merged into their development branch. You can give that a try instead of relying on this secondary module method.

from magento2-mandrill.

lgrassini avatar lgrassini commented on June 2, 2024

Thanks @Silarn ... So far it is working with your fix. I will wait until they merge your PR into the stable branch.

from magento2-mandrill.

centerax avatar centerax commented on June 2, 2024

guys: we will release a new version with this included tomorrow.

from magento2-mandrill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.