Code Monkey home page Code Monkey logo

Comments (5)

flavorjones avatar flavorjones commented on August 30, 2024

ACK. #2317 is the underlying issue to follow. Hoping to have a fix out this weekend.

from signer.

flavorjones avatar flavorjones commented on August 30, 2024

See sparklemotion/nokogiri#2320 for the changes I'd like to make. Comments and feedback welcome.

If that PR is what lands in a patch release of Nokogiri v1.12, then the signer gem would need to make only one small change to accomodate, and I'd be happy to submit it as a PR. The patch would be something like:

diff --git a/lib/signer.rb b/lib/signer.rb
index 16b9d25..4941355 100644
--- a/lib/signer.rb
+++ b/lib/signer.rb
@@ -65,6 +65,7 @@ def initialize(document, noblanks: true, wss: true, canonicalize_algorithm: :c14
     self.document = Nokogiri::XML(document.to_s) do |config|
       config.noblanks if noblanks
     end
+    self.document.namespace_inheritance = true if self.document.respond_to?(:namespace_inheritance)
     self.digest_algorithm = :sha1
     self.wss = wss
     self.canonicalize_algorithm = canonicalize_algorithm
diff --git a/signer.gemspec b/signer.gemspec
index ad5ca9f..405d6af 100644
--- a/signer.gemspec
+++ b/signer.gemspec
@@ -21,5 +21,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec'
 
-  gem.add_runtime_dependency 'nokogiri', '>= 1.5.1'
+  gem.add_runtime_dependency 'nokogiri', '>= 1.5.1', '!=1.12.3', '!=1.12.2', '!=1.12.1', '!=1.12.0'
 end

from signer.

flavorjones avatar flavorjones commented on August 30, 2024

I expect to ship Nokogiri v1.12.4 today making a workaround available. I've submitted a PR to signer at #31 which I'll change from "draft" to "ready" shortly thereafter.

from signer.

flavorjones avatar flavorjones commented on August 30, 2024

Nokogiri 1.12.4 is out, and #31 is ready for review.

from signer.

Envek avatar Envek commented on August 30, 2024

#29 seems to be related to this

from signer.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.