Comments (5)
ACK. #2317 is the underlying issue to follow. Hoping to have a fix out this weekend.
from signer.
See sparklemotion/nokogiri#2320 for the changes I'd like to make. Comments and feedback welcome.
If that PR is what lands in a patch release of Nokogiri v1.12, then the signer gem would need to make only one small change to accomodate, and I'd be happy to submit it as a PR. The patch would be something like:
diff --git a/lib/signer.rb b/lib/signer.rb
index 16b9d25..4941355 100644
--- a/lib/signer.rb
+++ b/lib/signer.rb
@@ -65,6 +65,7 @@ def initialize(document, noblanks: true, wss: true, canonicalize_algorithm: :c14
self.document = Nokogiri::XML(document.to_s) do |config|
config.noblanks if noblanks
end
+ self.document.namespace_inheritance = true if self.document.respond_to?(:namespace_inheritance)
self.digest_algorithm = :sha1
self.wss = wss
self.canonicalize_algorithm = canonicalize_algorithm
diff --git a/signer.gemspec b/signer.gemspec
index ad5ca9f..405d6af 100644
--- a/signer.gemspec
+++ b/signer.gemspec
@@ -21,5 +21,5 @@ Gem::Specification.new do |gem|
gem.add_development_dependency 'rake'
gem.add_development_dependency 'rspec'
- gem.add_runtime_dependency 'nokogiri', '>= 1.5.1'
+ gem.add_runtime_dependency 'nokogiri', '>= 1.5.1', '!=1.12.3', '!=1.12.2', '!=1.12.1', '!=1.12.0'
end
from signer.
I expect to ship Nokogiri v1.12.4 today making a workaround available. I've submitted a PR to signer at #31 which I'll change from "draft" to "ready" shortly thereafter.
from signer.
Nokogiri 1.12.4 is out, and #31 is ready for review.
from signer.
#29 seems to be related to this
from signer.
Related Issues (13)
- Getting XMLSEC format with signer HOT 4
- How to overwrite the CanonicalizationMethod tag? HOT 2
- Output ds:Signature instead of Signature HOT 2
- Removing namespaces and elements
- undefined method `request' for #<Savon::Client:0x007fef0fa21998> (NoMethodError)
- Convert example to Savon2
- gost2012, ruby > 2.3.1 HOT 6
- Should `transform` include both transform for if `option[:enveloped]` is true? HOT 5
- Ability to change Transform Algorithm and Reference URI
- Some support question HOT 2
- NoMethodError: undefined method `at_xpath' for nil:NilClass HOT 4
- RequireIssuerSerialReference in the SecurityTokenReference HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from signer.