Comments (4)
ArtBlue
commented on August 18, 2024
@ratinsl , these icons broke our script again. It looks like you have refs in there and you're using the same refs. Every ref needs to be unique. Also, can you please attach the zip when you have the new corrected icons? It's better to have a static set of changes attached to an issue than a reference to somewhere else the icons live.
from skin.
ArtBlue
commented on August 18, 2024
I'm blocking this issue until we have the correct icons.
from skin.
ratinsl
commented on August 18, 2024
@ArtBlue updated and corrected the refs/ids like we spoke about over slack and attached a zip folder vs the google drive folder. Please test and let me know if there are any other adjustments we need to make.
from skin.
ArtBlue
commented on August 18, 2024
For this issue, we're only adding non-gradient icons (spectrum). The gradient icons will be added in a future issue after we've created support for icon gradients.
from skin.
Related Issues (20)
- icon-button: refactor module and remove overrides in other modules HOT 1
- listbox-button: Focus ring inside list is clipped HOT 1
- 240327 - Skeleton fill/shimmer token updates
- textbox: text resize doesn't scale when styles were inherited at 200%
- 240408 - Icon Updates
- toggle-button-group: add equal heights and make fully responsive HOT 3
- progress-bar-expressive: expressive progress bar reading aloud too much in docs
- Toggle button: Add additional states HOT 1
- Editor config conflicts with prettier defaults
- Image: Account for disabled state HOT 1
- ebay-listbox-button: Add support for trailing support text in values
- icon: large CSS is mostly unused HOT 2
- Refactor links from `ebay.github.io` to `opensource.ebay.com`
- lightbox dialog: Title should wrap instead of using ellipses HOT 2
- ebay-listbox: add support for secondary text HOT 1
- ebay-icon: remove all duplicate classes
- 18.0.0: remove deprecated code
- Search text input field HOT 1
- 240531 - Icon Updates
- Convert application to sass HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skin.