Code Monkey home page Code Monkey logo

Comments (5)

supnate avatar supnate commented on August 28, 2024

hmm, I remember calling modal.show(modal, args) can use any prop name.

from nice-modal-react.

supnate avatar supnate commented on August 28, 2024

Just tried and it works but with typescript error.
Need to fix the type check of modal.show().

export const MyAntdModal = NiceModal.create(({ name , id}: { name: string, id: string }) => {
  const modal = useModal();
  return (
    <Modal title="Hello Antd" visible={modal.visible} onOk={modal.hide} onCancel={modal.hide} afterClose={modal.remove}>
      Greetings: {name} ({id})!
    </Modal>
  );
});

export default function AntdSample() {
  return (
    <Space>
      <Button type="primary" onClick={() => {
        //@ts-ignore
        NiceModal.show(MyAntdModal, { name: 'Nate', id: 'nateid' })}
      }>
        Show Modal
      </Button>
    </Space>
  );
}

from nice-modal-react.

czkoudy avatar czkoudy commented on August 28, 2024

Hi @supnate any luck with this?

from nice-modal-react.

supnate avatar supnate commented on August 28, 2024

Type check now fixed in v1.2.12. You can use id prop now.

from nice-modal-react.

chj-damon avatar chj-damon commented on August 28, 2024

@supnate I'm using 1.2.13 and still facing the same problem. typescript still reports error because I passed id prop as number type

from nice-modal-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.