Can't Get Combo View about kicadstepupmod HOT 7 CLOSED

I managed to make the export button work with this ugly thing:

diff --git a/kicadStepUptools.py b/kicadStepUptools.py
index 7ae55fe..2d86899 100644
--- a/kicadStepUptools.py
+++ b/kicadStepUptools.py
@@ -21732,6 +21732,12 @@ if singleInstance():
         cv = t.findChild(QtGui.QDockWidget, "Model")
         if cv is None:
             cv = t.findChild(QtGui.QDockWidget, "Tree view")
+            if cv is None:
+                cv = [o for o in t.children () if o.objectName () == "Combo View"]
+                if cv:
+                    cv = cv[0]
+                else:
+                    cv = None
     #say( "Combo View" + str(cv))
     ## print( "KSUWidget" + str(wf))        
     cv.setFeatures( QtGui.QDockWidget.DockWidgetMovable | QtGui.QDockWidget.DockWidgetFloatable|QtGui.QDockWidget.DockWidgetClosable )

Should I make a pull request for this?
from kicadstepupmod.

Should I make a pull request for this?

yes please

@ https://github.com/easyw/kicadStepUpMod/blob/56df083ae33473b5eb7698307ed181cb5c771032/kicadStepUptools.py#L1371
I also did this:

    cv = t.findChild(QtGui.QDockWidget, "Combo View")
    if cv is None:
        cv = t.findChild(QtGui.QDockWidget, "ComboView")
        if cv is None:
            cv = t.findChild(QtGui.QDockWidget, "Model")
            if cv is None:
                cv = t.findChild(QtGui.QDockWidget, "Tree view")

does it work for you?

from kicadstepupmod.

does it work for you?

It does not and it can be fixed the same way, but then the next lines start to fail, starting @ https://github.com/easyw/kicadStepUpMod/blob/56df083ae33473b5eb7698307ed181cb5c771032/kicadStepUptools.py#L1384

    if KSUWidget and cv:
        dw=t.findChildren(QtGui.QDockWidget)
        try:
            t.tabifyDockWidget(cv,KSUWidget)                
        except:
            pass
        k_tab = t.findChild(QtGui.QDockWidget, "kicadStepUp") #"kicad StepUp 3D tools")  # L1384 -> returns None  
        k_tab.activateWindow()  # Error

I tried to fix this in a similar way, by checking the children names in a loop, but none of the children have the name "kicadStepUp". I even checked recursively for "kicadStepUp". Without fixing the code you mentioned, the window can't be docked, but at least appears.

from kicadstepupmod.

hi @mampir
I cannot reproduce your issue...
could you please attach a zipped version of your FreeCAD 'user.cfg' file?

from kicadstepupmod.

user.cfg.zip
Here you go. You may also note, that I'm using I'm using this packaging of FreeCAD: https://www.parabola.nu/packages/libre/x86_64/freecad/

from kicadstepupmod.

@mampir
I cannot reproduce your issue...
it could be related to your distribution/packaging...
I'm closing it for the moment

from kicadstepupmod.

That's very disappointing and annoying. Of course it is because of different distribution and packaging - people use more than one distribution and packaging in this world. You could have just implemented the simple fix I already submitted.

from kicadstepupmod.