Comments (3)
sgwilym
commented on July 3, 2024
I think I know what this is: currently we are writing to local storage on every document write. This change to local storage is firing off the hooks which read the storage, causing the app to re-render. For each write there's a re-render, so if you have a workspace like lobbydev.
Is it true that we're only interested in reading from localstorage once, at startup? If so, maybe we don't need the hooks support at all.
from react-earthstar.
cinnamon-bun
commented on July 3, 2024
If localstorage changes in another tab, we want to re-render this tab. But not if it changes because of something we did in the current tab.
I would assume the useLocalstorage library is smart about this but I might be wrong...
from react-earthstar.
sgwilym
commented on July 3, 2024
This seems to be fixed in apps like lobby and status!
from react-earthstar.
Related Issues (20)
- Add styling guide
- Actually delete workspaces when they are removed
- Add UI for live syncing HOT 1
- Author a few default Earthbar themes HOT 1
- Create an onboarding tab HOT 1
- Create component for redeeming + creating Earthstar invitations
- Invite code has "undefined" as workspace
- Maybe only sync the active workspace?
- Add a pronouns.json in /about with Earthbar UI
- Earthbar: click outside a tab to close it HOT 3
- Variety of small CSS issues
- add button works when pub field is blank
- Current workspace is only remembered if you're logged in as a user
- Can't remove the last workspace HOT 1
- Recursive duplication of Storage data in localStorage HOT 6
- useDocuments(query) doesn't always update on deletions, because of paths() query limits HOT 2
- FocusSyncer is triggered multiple times at once when switching back to a tab HOT 3
- Storages are `close()`d in unneeded situations HOT 1
- The path to React 18 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-earthstar.