Clean clip.py code AND capitalize comment on line 322 of spatial.py code about earthpy HOT 7 CLOSED

@tkarfs1 i'm assigning this to @mbjoseph but did want to give you a heads up that i believe spatial.py has been worked on already for PEP 8 and there is a second proposal to work on it here.

#74

so you will need to submit a separate fix for item 1.

To see that this work was done - please update your fork. We will need you to submit another fix given my comment above. I believe no one has proposed to document plot_bands so you should be good on your second proposed item.
I am assigning this issue to my good colleague @mbjoseph !

from earthpy.

Hi @lwasser @mbjoseph can I still capitalize "test" in line 322?

from earthpy.

Hello @tkarfs1 - yes that is a valid change that still needs doing. However your second change, to document plot_bands(), has already been fixed (see the most recent documentation here: https://github.com/earthlab/earthpy/blob/master/docs/spatial-raster.rst#plot-raster-file-bands).

Can you propose an alternative second change to make?

Thanks!

from earthpy.

Thanks @mbjoseph ! I'll also apply pep 8 standards to the clip.py code. It looks like I can delete some white space in that notebook.

from earthpy.

Ok sounds good @tkarfs1. When you submit your pull request please "@" me by including @mbjoseph!

from earthpy.

This change has been implemented via pull request BUT there seems to be a conflict with the base in relation to deleted whitespace in clip.py

from earthpy.

Nice job @tkarfs1! Thanks for the pull request

from earthpy.