Code Monkey home page Code Monkey logo

Comments (4)

mbjoseph avatar mbjoseph commented on June 3, 2024 1

Hello @mirob9363! Thanks for opening this issue. See below for some things to think about:

  1. Good catch! If you could add a description of the title argument to the docstring for the plot_bands function, that would be great. In this description, it's worth describing the behavior of the title argument when the user passes a string vs. when they leave the argument as None (see the code to find out what happens in these two cases).

  2. Sounds good! I would recommend following the structure of the description of stack_raster_tifs, and including a simple example of using the plot_bands function.

When you submit your pull request, please "@" me by including @mbjoseph in the text description. Thanks!

from earthpy.

PowerChell avatar PowerChell commented on June 3, 2024 1

This change has been implemented. Please see pull request
#82

from earthpy.

PowerChell avatar PowerChell commented on June 3, 2024

Hi @mbjoseph!
Great, I will address your suggestions. It has also come to my attention that the plot_bands docstring also has a typo: in the description of the parameter col, columsn should be columns. Could I also fix this typo when adding the parameter title?

from earthpy.

mbjoseph avatar mbjoseph commented on June 3, 2024

Sounds good @mirob9363!

from earthpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.