Comments (5)
Updated issue 2 to be more clear.
from earthpy.
Hello @willskor! Thanks for opening this issue. See below for some details:
- This is great. I am also noticing that the
arr_out
argument is not described in the docstring forstack_raster_tifs
. https://github.com/earthlab/earthpy/blob/master/earthpy/spatial.py#L71-L78
If you can add a description of what the arr_out
argument expects and what it does to both the spatial-raster.rst
file and the earthpy/spatial.py
file, that would be awesome!
- This sounds good. I would recommend formatting the comments to match PEP 8, and changing the comments to be something like:
https://github.com/earthlab/earthpy/blob/master/earthpy/spatial.py#L66 changes to
# TODO: include a no data value here if provided ...
https://github.com/earthlab/earthpy/blob/master/earthpy/spatial.py#L252-L253 changes to
# TODO: verify colorbar works with the latest matplotlib, and is not too wide
I would just delete these two comments: https://github.com/earthlab/earthpy/blob/master/earthpy/spatial.py#L344-L345 The first comment is redundant with the docstring for plot_rgb
, and the second comment seems to be more of an internal dialogue from the developer, that doesn't need to persist in the source code.
When you submit your pull request, please "@" me by including @mbjoseph in the pull request description. Thanks!
from earthpy.
Thanks Max, will do!
One last thing. I'm also confused about this comment: https://github.com/earthlab/earthpy/blob/master/earthpy/spatial.py#L65
I'm not sure what it is referring to.
This is another example of some code that should probably be deleted, or made into a TODO:
https://github.com/earthlab/earthpy/blob/master/earthpy/spatial.py#L441
from earthpy.
I think you can go ahead and delete https://github.com/earthlab/earthpy/blob/master/earthpy/spatial.py#L65
For https://github.com/earthlab/earthpy/blob/master/earthpy/spatial.py#L441, it would be great if you could replace the existing comment with:
# TODO: write test case for just one color
Thanks @willskor!
from earthpy.
Solved by #68
from earthpy.
Related Issues (20)
- plot_rgb fails with stretch=True for masked array with masked NaNs HOT 1
- Issue in Docs - incorrect url is breaking CI HOT 1
- Doubt on using NDVI for Sentinel-1 images
- Issue with plotting nan values. HOT 1
- Update dependencies HOT 1
- check_crs additional testing needed
- Fix Linting tests to run both black and flake8
- Issue with downloading `et.data.get_data()` HOT 2
- `_stretch_im` not working as intended HOT 4
- overlay shapefile on raster based on raster extent
- em.pixel_flags is poorly documented HOT 1
- Update vignettes to use rioxarray
- `earthpy.plot.plot_bands` method ignores `ax` keyword argument if raster has multiple bands HOT 2
- Earthpy Compatibility with Matplotlib
- Several tests are failing HOT 7
- BadZipFile: File is not a zip file HOT 1
- Error produced when I try to run earthpy with my new environment (that includes earthpy). HOT 6
- Support APPEEARS downloads
- Custom file download location HOT 1
- Add option to keep axes ticks and labels
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from earthpy.