Code Monkey home page Code Monkey logo

Comments (8)

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024

Original comment by [email protected] on 12 Feb 2007 at 12:12

  • Added labels: Milestone-Release0.6, Priority-High, Type-Enhancement
  • Removed labels: Priority-Medium, Type-Defect

from iwidarwin.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
"mbf" is bad function name ( everybody dont undersntad the meaning ). 

this is named like a  "mbuf_freem_list_with_check".

and "is critical to free the memory" is bad description. 

this should be "added routine to avoid double free."

if u agree me , i merge this after renaming "mbf" to 
"mbuf_freem_list_with_check".

Original comment by [email protected] on 12 Feb 2007 at 7:39

from iwidarwin.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
ok :)

Original comment by [email protected] on 13 Feb 2007 at 5:13

from iwidarwin.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
jalavoui, i has one question. 
why do u use not freePacket but mbuf_freem_list ?
i seem that mbuf_freem_list should not be called directly.

void IONetworkController::freePacket(struct mbuf * m, IOOptionBits options)
{
    assert(m);

    if ( options & kDelayFree )
    {
        m->m_nextpkt = _freeList;
        _freeList = m;
    }
    else
    {
        m_freem_list(m);
    }
}


int     mbuf_freem_list(mbuf_t mbuf)
{
        return m_freem_list(mbuf);
}

Original comment by [email protected] on 13 Feb 2007 at 9:50

from iwidarwin.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
i'll try that

Original comment by [email protected] on 13 Feb 2007 at 10:33

from iwidarwin.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
at first. 
I will define freePacket_withCheck like a following in mbf.
inline void freePacket_withCheck(mbuf_t m)
{

        if( m != NULL && mbuf_len(m)!=0 && mbuf_type(m)!=MBUF_TYPE_FREE)
            mbuf_freem_list(m);
}

and mbf() -> freePacket_withCheck().


Original comment by [email protected] on 13 Feb 2007 at 11:48

from iwidarwin.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024
sorry s/mbuf_free_list/freePacket/

Original comment by [email protected] on 13 Feb 2007 at 11:50

from iwidarwin.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 12, 2024

Original comment by [email protected] on 16 Feb 2007 at 5:02

  • Changed state: Fixed

from iwidarwin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.