Comments (9)
@VerifiedGruber @femtotrader Hey guys, just merged the above request to get this package working for current Julia versions. I've released a new version for these updates (v0.1.0
) and opened the pull request on Julia's METADATA repository to get this work pushed out.
Closing this issue for now, let me know if you guys experience any more issues and we can continue making improvements. Thanks again for raising this issue, and thanks to @femtotrader for all the leg work he did to minimize the final steps required to get this done. Cheers guys.
from strategems.jl.
A good way to know if a developer is alive (ie still active) is by submitting him pull request.
Somes examples:
from strategems.jl.
@VerifiedGruber @femtotrader Thanks for bringing this to light guys, looking into it now. Will review the PR changes and try to figure out what's required to get this working again.
Also, my apologies for the lag in getting this package up to date with newer Julia versions.
from strategems.jl.
https://github.com/dysonance/Strategems.jl/blob/master/src/rule.jl#L15-L21
doesn't work with Julia 0.7.
It raises
ERROR: syntax: "..." expression outside call
from strategems.jl.
Not sure if that's a correct fix or not:
https://github.com/dysonance/Strategems.jl/pull/19/files#diff-a7f10850a9e8c4fb546b622a1813a813L19
from strategems.jl.
Tests are passing with Julia 0.7 so:
- maybe that's fixed or
- maybe test coverage is not enough
from strategems.jl.
A good way to know if a developer is alive (ie still active) is by submitting him pull request.
Somes examples:
I cloned the repository and tested the code on the 0.6.4v, yet, the code seems to be incompatible due to Indicator's being 0.6.0v only (That's what I took from the error I received), and there's no Windows binary for the older 0.6.0v release. So now I'm compilling that specific version to run it properly and port it to 1.0.0v as a pull request eventually.
from strategems.jl.
https://github.com/dysonance/Strategems.jl/blob/master/src/rule.jl#L15-L21
doesn't work with Julia 0.7.
It raises
ERROR: syntax: "..." expression outside call
This seems similar to:
JuliaLang/julia#23218
Where building a tuple inside a tuple literal happens to raise an error on 0.7.0v. Although I don't have any meaningful fixes for that, did you fix that on your new branch? If you didn't, could you make an specific issue for it?
from strategems.jl.
Not sure if that's a correct fix or not:
https://github.com/dysonance/Strategems.jl/pull/19/files#diff-a7f10850a9e8c4fb546b622a1813a813L19
I think that's the correct fix. The splat there is forcefully converting the variable to a possible array, whereas 0.7.0v does this conversion automatically when needed. This should result in a conflict that is resolved when you remove the (...), the question is, why that didn't happen with the other splats? Maybe they all were used as arrays and that specific variable didn't?
Edit: I investigated further, and found that 0.7.0v supports direct specification of splatting interpolation:
https://docs.julialang.org/en/v0.7/manual/metaprogramming/#Splatting-interpolation-1
Where I can only find proper "..." usage on 0.6.0v here:
https://docs.julialang.org/en/v0.6.0/manual/faq/#The-two-uses-of-the-...-operator:-slurping-and-splatting-1
Which the splatting operator only works in the function definition as an operator to "soak a list", as classical programming and other languages do. I am confused if your fix works as the original intended to, we'll see. Good to see the build is passing, I'm going to try your changes to the code and report back.
from strategems.jl.
Related Issues (20)
- Order Type Implementations HOT 2
- Sample data and reorganisation / chunk of data HOT 1
- LoadError: UndefVarError: @signal not defined while loading /Users/balupton/Projects/trading/JuliaTrading.jl/strat.jl, in expression starting on line 30 HOT 1
- get_run_params is broken HOT 6
- WARNING: .== is no longer a function object; use broadcast(==, ...) instead HOT 1
- Shouldn't use global variable inside testset
- Parallelism HOT 6
- "LoadError: syntax: "..." expression outside call" HOT 2
- Run examples as part of unit test HOT 1
- Example from README is not working HOT 2
- Logical Operators for Signals/Rules HOT 1
- Is this library dead? HOT 1
- ParameterSet, parameters as named tuples and constraints HOT 1
- Documentation HOT 3
- Example from README is not working - v2
- More organized test cases HOT 1
- Parameter exploration - nicer API HOT 4
- Parameter Set Constraints HOT 3
- Random Sampling of Parameter Space Combinations HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strategems.jl.