Comments (8)
I got hit by missing CONFIG_MODVERSIONS this week. Shall we add a check in kpatch-build? Or better, shall we select MODVERSIONS with CONFIG_LIVEPATCH? (Maybe I should ask the second question in the mail list?)
from kpatch.
I got hit by missing CONFIG_MODVERSIONS this week. Shall we add a check in kpatch-build? Or better, shall we select MODVERSIONS with CONFIG_LIVEPATCH? (Maybe I should ask the second question in the mail list?)
Hi @liu-song-6 ,
- When you say you "got hit by missing CONFIG_MODVERSIONS", is that in reference to kpatch integration tests, or did you have to debug a kpatch that tweaked exported symbol abi?
- The kpatch integration tests assume the same result for all arches and configs. Perhaps they could be made more aware of their environment.
- MODVERSIONS is a nice safety feature when building kpatches, but maybe there is other tooling that generates livepatches that can make do without it? And/or some distros that would want to livepatch even without MODVERSIONS?
from kpatch.
When you say you "got hit by missing CONFIG_MODVERSIONS", is that in reference to kpatch integration tests, or did you have to debug a kpatch that tweaked exported symbol abi?
I was trying to make kpatch-build work for a kernel without CONFIG_MODVERSIONS. kpatch-build works, but the patch cannot load. The fix was to reenable CONFIG_MODVERSIONS.
I think we can have kpatch-build check whether CONFIG_MODVERSIONS is enabled. If it is not, kpatch-build fails. Is this reasonable?
from kpatch.
I was trying to make kpatch-build work for a kernel without CONFIG_MODVERSIONS. kpatch-build works, but the patch cannot load. The fix was to reenable CONFIG_MODVERSIONS.ing to make kpatch-build work for a kernel without CONFIG_MODVERSIONS. kpatch-build works, but the patch cannot load. The fix was to reenable CONFIG_MODVERSIONS.
Interesting, so setting CONFIG_MODVERSIONS alone fixed the kpatch.ko load, or did it help point out inadvertent symvers change?
I think we can have kpatch-build check whether CONFIG_MODVERSIONS is enabled. If it is not, kpatch-build fails. Is this reasonable?
That would affect distros like Fedora, which probably aren't the best use case for kpatch, but certainly handy for development and testing. How about a warning?
from kpatch.
Interesting, so setting CONFIG_MODVERSIONS alone fixed the kpatch.ko load, or did it help point out inadvertent symvers change?
In this case, setting CONFIG_MODVERSIONS fixes the issue.
That would affect distros like Fedora, which probably aren't the best use case for kpatch, but certainly handy for development and testing. How about a warning?
A warning should also work.
Thanks,
Song
from kpatch.
What error message did you see when the patch failed to load? I'm trying to understand why enabling CONFIG_MODVERSIONS fixed it.
from kpatch.
This issue has been open for 30 days with no activity and no assignee. It will be closed in 7 days unless a comment is added.
from kpatch.
This issue was closed because it was inactive for 7 days after being marked stale.
from kpatch.
Related Issues (20)
- Do we need more robust archeticture protection HOT 4
- kpatch-build: verify_patch_files might miss a parameter HOT 2
- ERROR in find_local_syms, couldn't find matching XXX local symbols in vmlinux symbol table HOT 14
- Can you add support for Rocky and Alma? HOT 1
- relocation with type R_X86_64_GOTPCREL is not supported HOT 5
- Arch Compile kpatch-git test failed HOT 4
- Regarding "statically allocated data" again HOT 2
- kpatch-build error when modifying an object file's only syscall
- nowhere to find the definition of klp_register_patch HOT 5
- x86 paravirt code uses alternatives v6.8+ HOT 1
- special-static.patch can fail to build on s390x / upstream v6.8 HOT 6
- CONFIG_FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY not supported on ppc64le HOT 6
- function __pfx_new_sync_read has no fentry/mcount call, unable to patch HOT 6
- Unchanged and unpatchable function moves from .text to .text.unlikely HOT 5
- Why did the kpatch-build script export the KPATCH-BUILD environment variable from the BUILD directory to the SOURCE directory? HOT 3
- CONFIG_WERROR=y and CONFIG_LD_ORPHAN_WARN_LEVEL="error" break kpatch-build HOT 2
- linux 6.9.0-rc6 can't find special struct paravirt_patch_site size HOT 6
- fair.o: changed section .data..read_mostly not selected for inclusion HOT 9
- find_local_syms: 218: couldn't find matching cm.c local symbols in ib_mad symbol table HOT 5
- Kernel Warning: Unpatched return thunk in use. This should not happen! HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kpatch.