changes to __init function not detected about kpatch HOT 4 CLOSED

This was fixed by #114, but an outstanding question remains. Why did we have to hard code the edge case checking, instead of it getting caught by the inclusion checking logic?

from kpatch.

@jpoimboe this is on my list to check out.

from kpatch.

Coming back to this, I reverted 7b15e23 and tried to recreate this issue but couldn't. I get the expected result:

$ kpatch-build patch
Using cache at /home/sjennings/.kpatch/3.13.10-200.fc20.x86_64/src
Testing patch file
patching file fs/proc/meminfo.c
Building original kernel
Building patched kernel
Detecting changed objects
Rebuilding changed objects
Extracting new and modified ELF sections
meminfo.o: changed function: meminfo_proc_show
meminfo.o: changed section .init.text not selected for inclusion
/usr/local/libexec/kpatch/create-diff-object: unreconcilable difference
ERROR: kpatch build failed. Check /tmp/kpatch-build-1398711757.log for more details.

I'm not sure if I tried to recreate this issue before "fixing" it. @jpoimboe can you recreate after reverting the fix?

from kpatch.

Yeah, that's really weird, I'm not able to recreate either. I guess it must have been user error somehow. So we can revert that commit.

from kpatch.