Code Monkey home page Code Monkey logo

Comments (32)

baba43 avatar baba43 commented on May 29, 2024 12

We definitely need this before we can use this library.

Sadly I could not find any workaround to make it work, so it would be awesome to see this added :)

from react-native-fast-image.

anhtuank7c avatar anhtuank7c commented on May 29, 2024 12

You all can use wrap by View and use overflow: hidden, borderRadius: 5
RN support hidden on Android from version 0.50

from react-native-fast-image.

vit3k avatar vit3k commented on May 29, 2024 3

For me it works on simulator but not on Samsung S6.

from react-native-fast-image.

vvavepacket avatar vvavepacket commented on May 29, 2024 2

@Akillis which fixed u mean? I tried adding borderRadius to the component,, but it is still squared..

from react-native-fast-image.

jslok avatar jslok commented on May 29, 2024 1

+1

from react-native-fast-image.

jslok avatar jslok commented on May 29, 2024 1

@Akillis it doesn't work for me. Looks like you need to know the exact size of the image beforehand too.

from react-native-fast-image.

vvavepacket avatar vvavepacket commented on May 29, 2024 1

guys it works on iOS, but not on android

from react-native-fast-image.

wmonecke avatar wmonecke commented on May 29, 2024 1

This is still not working on android:

"react-native": "0.47.1",
"react-native-fast-image": "^5.0.3",

from react-native-fast-image.

anhtuank7c avatar anhtuank7c commented on May 29, 2024 1

@wmonecke You have to upgrade to RN 0.50.0 or newer version

from react-native-fast-image.

coucoseth avatar coucoseth commented on May 29, 2024 1

was borderRadious added because it isnt working on my end on android

from react-native-fast-image.

DylanVann avatar DylanVann commented on May 29, 2024

It's not supported currently. I'll look into how easy it would be to add.

from react-native-fast-image.

pfulop avatar pfulop commented on May 29, 2024

Well I switched to react-web-image and found out there is beta branch which has this funcionality implemented. vovkasm/react-native-web-image#2 . You can find inspiration there if it is still relevant for you.

from react-native-fast-image.

grundmanise avatar grundmanise commented on May 29, 2024

So even if we wrap it inside a View and set a borderRadius & overflow: 'hidden' on that View the image won't be clipped?

from react-native-fast-image.

bestlbw avatar bestlbw commented on May 29, 2024

i think u can look this to support radius,https://github.com/wasabeef/glide-transformations

from react-native-fast-image.

RUIFERNANDE5 avatar RUIFERNANDE5 commented on May 29, 2024

Yea, borderRadius not being supported is quite a bummer, would be awesome if we got it

from react-native-fast-image.

tsaohucn avatar tsaohucn commented on May 29, 2024

Need this too.

from react-native-fast-image.

dorthwein avatar dorthwein commented on May 29, 2024

Same here.... ;(

from react-native-fast-image.

gitlovenotwar avatar gitlovenotwar commented on May 29, 2024

+1, even a parent view with border radius and overflow hidden, the image won't get clipped. Using react-native Image component, is working(though their caching fails on ios)

from react-native-fast-image.

tuvshinbatgeru avatar tuvshinbatgeru commented on May 29, 2024

How about that.

<View style={styles.circle}> <FastImage style={styles.image} /> <View style={styles.fixCircleClipping}/> </View>

circle: { width: circleSize, height: circleSize, borderRadius: circleSize / 2, overflow: 'hidden', }, fixCircleClipping: { position: 'absolute', top: -circleFixBorder, bottom: -circleFixBorder, right: -circleFixBorder, left: -circleFixBorder, borderRadius: circleSize / 2 + circleFixBorder / 2, borderWidth: circleFixBorder, borderColor: bgColor },

from react-native-fast-image.

anhtuank7c avatar anhtuank7c commented on May 29, 2024

@Akillis overflow: 'hidden' does not supported on Android

from react-native-fast-image.

vvavepacket avatar vvavepacket commented on May 29, 2024

according here, #58 bordeRadius has been added, but when i tried on android, it does not work. did u guys managed to solve the issue?

from react-native-fast-image.

tuvshinbatgeru avatar tuvshinbatgeru commented on May 29, 2024

It is worked as i said. You need to try this out!.

from react-native-fast-image.

song50119 avatar song50119 commented on May 29, 2024

Same issue.

from react-native-fast-image.

gogumai avatar gogumai commented on May 29, 2024

@DylanVann it looks like #58 it's not on npm yet.

Can you please upload this feature?

Thanks!!

from react-native-fast-image.

tquiroga avatar tquiroga commented on May 29, 2024

Same issue

from react-native-fast-image.

OGPoyraz avatar OGPoyraz commented on May 29, 2024

Bump

from react-native-fast-image.

FlorianBergmann avatar FlorianBergmann commented on May 29, 2024

+1 for Android support

from react-native-fast-image.

tmaly1980 avatar tmaly1980 commented on May 29, 2024

Yes, I concur with @anhtuank7c . Just upgrade to RN 0.50.0 and use overflow:hidden on the view container (which I tend to use anyway for scaling purposes)

from react-native-fast-image.

tehwayne avatar tehwayne commented on May 29, 2024

would be nice to get this support vs wrapping all the images in views

from react-native-fast-image.

DylanVann avatar DylanVann commented on May 29, 2024

borderRadius support has been added. I went with the containing view solution for reasons outlined here: #59 (comment)

Thank you for the help!

from react-native-fast-image.

ezha86 avatar ezha86 commented on May 29, 2024

can anyone confirm that border radius does work on android ?
for me seems it doesnt
"react-native": "^0.53.0",
"react-native-fast-image": "^2.2.5",

from react-native-fast-image.

jesspinklet avatar jesspinklet commented on May 29, 2024

@coucoseth in our case we had to giva a background color to fast image as well in order to make it work.
backgroundColor: "transparent"
transparent bg works as well .

from react-native-fast-image.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.