Code Monkey home page Code Monkey logo

Comments (4)

dyelax avatar dyelax commented on June 17, 2024 2

Good catch. Fixed!

from adversarial_video_generation.

dyelax avatar dyelax commented on June 17, 2024

Hey @bsautermeister, thanks for the link! I'll check that out and integrate it when I have a chance. Or, if you'd like to add it in yourself and submit a pull request, I'd be happy to accept.

from adversarial_video_generation.

b3nk4n avatar b3nk4n commented on June 17, 2024

I will, as soon as I find time for that.

By the way: I'm not sure, but after comparing your PSNR implementation with it's formula in the paper and the PSNR Wikipedia-Definition for colored images:

For color images with three RGB values per pixel, the definition of PSNR is the same except the MSE is the sum over all squared value differences divided by image size and by three.

I think that you miss the by three. As you are using the formula for colored images and take the sum over all 3 dimension (tf.reduce_sum(...,[1, 2, 3]), I think you should consider the 3rd dimension for your num_pixels as well:

num_pixels = tf.to_float(shape[1] * shape[2] * shape[3])

Or am I wrong? :)

EDIT

Probably the same thing for sharpness-differences error as well...

from adversarial_video_generation.

daji2112 avatar daji2112 commented on June 17, 2024

I know this is very very late but I wanted to get the SSIM @dyelax or @bsautermeister, did one of you got the chance to integrate it with the code, or Is there any other way to calculate the SSIM for this paper like for example, compare_ssim or tf.image.ssim, even can we calculate the psnr with tf.image.psnr..... I would really appreciate a reply. Thank you for this helpful code @dyelax

from adversarial_video_generation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.