Add icons for each version control service about pipeliner HOT 3 CLOSED

Hello, I tried to create a pull request to fix this issue, but I am not able to create a pull request from my commit. Until i will figure it out here is my text for pull request:

Add icons for each version control service #10

Version control service icons added to:

• Configuration Picker (1)
• Saved configuration (2)
• Pipelines in Pipeliner app (3)
• Pipelines in Pipeliner Widget - small, medium and large (4)

Visible on the screenshots below.

GitHub icon was not standing out in dark mode so I added black and also white icon. Light mode uses black and dark mode uses white icon.

I added also Bitbucket option for the future, it is commented for now.

All the icons are from official assets(company websites), sized down to 18x18.png files. I don’t know how to resize NSImage, so after some time I resized the icons. If there is some simple solution I will be very happy to learn about it.


⚠️I had to add assets into build phases for Pipeliner and PipelinerWidget to be able to load the icons. It is not commited in github

I also added serviceType to PipelineResult, so I can load icon according to type for widget pipelines.

I hope that this changes will be useful.

BR,
Tom.

from pipeliner.

Hi 👋 Great job 👍I like white & black logo detail 🙂I can see png icons in Assets.xcaassets folder which I fine. Also i think you committed some of yours user data.../project.xcworkspace/xcuserdata/tomaskucharzyk.xcuserdatad/UserInterfaceState.xcuserstate which is unnecessary. Otherwise your PR is fine.

from pipeliner.

Thank you 🙂 should i remove the file? Or it is okay and i can leave it there?

from pipeliner.