Comments (3)
Hello, I tried to create a pull request to fix this issue, but I am not able to create a pull request from my commit. Until i will figure it out here is my text for pull request:
Add icons for each version control service #10
Version control service icons added to:
- Configuration Picker (1)
- Saved configuration (2)
- Pipelines in Pipeliner app (3)
- Pipelines in Pipeliner Widget - small, medium and large (4)
Visible on the screenshots below.
GitHub icon was not standing out in dark mode so I added black and also white icon. Light mode uses black and dark mode uses white icon.
I added also Bitbucket option for the future, it is commented for now.
All the icons are from official assets(company websites), sized down to 18x18.png files. I donβt know how to resize NSImage, so after some time I resized the icons. If there is some simple solution I will be very happy to learn about it.β¨β¨
I also added serviceType to PipelineResult, so I can load icon according to type for widget pipelines.
I hope that this changes will be useful.
BR,
Tom.
from pipeliner.
Hi π Great job πI like white & black logo detail πI can see png icons in Assets.xcaassets folder which I fine. Also i think you committed some of yours user data.../project.xcworkspace/xcuserdata/tomaskucharzyk.xcuserdatad/UserInterfaceState.xcuserstate
which is unnecessary. Otherwise your PR is fine.
from pipeliner.
Thank you π should i remove the file? Or it is okay and i can leave it there?
from pipeliner.
Related Issues (20)
- Add BitBucket Support HOT 2
- Improve TextField description for GitLab UI HOT 13
- Add GitHub configuration UI HOT 1
- Add BitBucket configuration UI
- Pipeliner service can work with multiple version control services
- Improve error handling HOT 1
- Widget click leads to browser
- Improve UX in light mode HOT 17
- Refactor way of counting number of fetched pipelines
- Add GitLab pull request support
- Add GitHub pull request support
- Add BitBucket pull request support
- Refactor PipelinerService to work with pull requests
- UI can display pull requests
- Add in progress pipeline state HOT 1
- Reuse API token when user already has API token for that VCS
- Refresh widget when config is changed
- Refresh widget when configuration is changed
- Github web adress HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pipeliner.