Code Monkey home page Code Monkey logo

Comments (3)

pscheid92 avatar pscheid92 commented on September 23, 2024 2

Hello again @nelsonic πŸ‘‹

The misattributions now have their own issues (#43 and #44). I opened PR #42 for the remaining parts of this issue; I tried to split the changes into meaningful commits, hopefully easing the review.

from quotes.

nelsonic avatar nelsonic commented on September 23, 2024 1

@pscheid92 excellent! Thanks! πŸ™Œ

from quotes.

nelsonic avatar nelsonic commented on September 23, 2024

Hi @pscheid92 πŸ‘‹
Stoked you found the repo and you have proactively opened this issue to help us decuplicate it! πŸŽ‰
Agree with all your suggestions. Pick the name that is most used e.g β€œLau Tsu” in English.
Even though the Wikipedia article is titled β€œLaozi” https://en.m.wikipedia.org/wiki/Laozi
When a quote has been attributed to multiple people maybe let’s open an issue for each one and do a Quote Investigator https://quoteinvestigator.com lookup for each one. πŸ€”

We would be delighted if you have time to open a pull request with fixes. πŸ’‘
Thanks!

from quotes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.