Code Monkey home page Code Monkey logo

Comments (18)

iteles avatar iteles commented on September 12, 2024 1

I'll settle for running the site through wave.webaim.org and having it pass with no errors and minimal alerts 😊
We probably need to do some looking into how closely wave follows WCAG 2.0

Note: ngrok could again come in handy for this whilst you're testing locally (#244 (comment))

from dwyl-site.

 avatar commented on September 12, 2024 1

@ZooeyMiller let's have underline as a link convention for all text links in page text (not nav and footer links etc)

from dwyl-site.

iteles avatar iteles commented on September 12, 2024

A great post from @Charlotteis to help with this, mentioned in #83.
https://github.com/dwyl/dwyl.github.io/issues

from dwyl-site.

Cleop avatar Cleop commented on September 12, 2024

@iteles -

  • Would you be able to elaborate on what this issue means?
  • Is it all covered in #83?
  • Is this now out of date and ready to close?

from dwyl-site.

 avatar commented on September 12, 2024

@iteles would you be able to provide a list of requirements (checkboxes) to close this issue?

from dwyl-site.

iteles avatar iteles commented on September 12, 2024

https://www.wuhcag.com/wcag-checklist/

Tools like https://www.powermapper.com/products/sortsite/checks/accessibility-checks/ and http://wave.webaim.org/ should help check this.

from dwyl-site.

 avatar commented on September 12, 2024

from dwyl-site.

iteles avatar iteles commented on September 12, 2024

This is going to throw up an error and needs to be fixed before we go live: 3aa6cf2#diff-d015ee2938b049b883af8932cc97a99bR58

from dwyl-site.

 avatar commented on September 12, 2024

@iteles can you clarify what needs changing?

from dwyl-site.

iteles avatar iteles commented on September 12, 2024

@markwilliamfirth Yes, sorry, href="#" is what will throw an accessibility error.

from dwyl-site.

ZooeyMiller avatar ZooeyMiller commented on September 12, 2024

We can use pa11y to check the site for accessbility, it has WCAG2 standards built in, but has the different levels as well, are we looking for A, AA or AAA rating? More info on the differences between the levels in the stack overflow answer.

On AA we get errors for contrast ratios, on A we do not.

from dwyl-site.

 avatar commented on September 12, 2024

@ZooeyMiller I just ran pa11y

npm install -g pa11y
pa11y http://dwyl.com

...and got this:

screen shot 2017-10-02 at 13 26 01

Do you get the same?

I think A is fine for now

from dwyl-site.

ZooeyMiller avatar ZooeyMiller commented on September 12, 2024

@markwilliamfirth as standard it with run with AA. run pa11y --ignore "warning;notice" --standard WCAG2A http://dwyl.com to run A and ignore warnings. Passes for me!

from dwyl-site.

 avatar commented on September 12, 2024

@ZooeyMiller 👍

pa11y --ignore "warning;notice" --standard WCAG2A http://dwyl.com

screen shot 2017-10-02 at 14 04 10

This passes! 🎉

Running through wave (http://wave.webaim.org/) we get:

screen shot 2017-10-02 at 14 05 28

Running through powermapper (https://www.powermapper.com/products/sortsite/checks/accessibility-checks/) we get:

screen shot 2017-10-02 at 14 06 14

screen shot 2017-10-02 at 14 06 22

@iteles I think meeting WCAG2 A is fine for now - what do you think?

from dwyl-site.

ZooeyMiller avatar ZooeyMiller commented on September 12, 2024

I'm going to look into fixing the accessibility issues you've mentioned in #14 (comment) Mark.

from dwyl-site.

ZooeyMiller avatar ZooeyMiller commented on September 12, 2024

One issue from sortsite is:

Removing the underline from links makes it hard for color-blind users to see them.

Is this a compromise we want to make? It is listed as an "A" level error. Related to #394

from dwyl-site.

ZooeyMiller avatar ZooeyMiller commented on September 12, 2024

report - google chrome_044

No red accessibility errors (red is for "A" standard, orange for "AA"). The other issues are worth looking into, but aren't accessibility so not strictly relevant for this issue.

from dwyl-site.

 avatar commented on September 12, 2024

@iteles are you happy with this level of accessibility? We can keep going but I think this is good enough for now

from dwyl-site.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.