Comments (6)
/**
* Whether the model should throw a ValidationException if it
* fails validation. If not set, it will default to false.
*
* @var boolean
*/
protected $throwValidationExceptions = true;
All in the readme
from validating.
Got that all in there. It throws exceptions when calling $model->save(), just not when calling $model->isValid('saving');
I was able to work around the issue by adding the following code:
if (!$user->isValid('saving')) {
$exception = new ValidationException(get_class($user) . ' model could not be persisted as it failed validation.');
$exception->setModel($user);
$exception->setErrors($user->getErrors());
throw $exception;
}
Looking at the source for the validation trait, is appears that the trait method performValidation() is overriding the observer method of the same name. The trait method does not throw an exception, while the observer method does.
from validating.
Haha, yeah it is. My reasoning was that asking a model if it isValid()
isn't necessarily an exceptional event. It just tells you whether it is or not. On the other hand, attempting to save a model that isInvalid()
should be considered an exceptional event.
I suppose one thing I could do is move the throwing of an exception into a method on the model, say throwValidationException()
. That it would be slightly easier for you to accomplish what you're after (but still not exactly what you're going for...):
if ( ! $user->isValid('saving')) $user->throwValidationException()
Actually, another alternative is (I'm thinking as I type!) is another method, like isValidOrFail('saving')
which would achieve what you're after without being totally weird about it. What do you think?
from validating.
Yes, I agree with the semantics :). Asking if something IS or ISNOT should return true or false. Is isInvalid()
simply the inverse of isValid()
, or will it actually throw an exception? If so, I'll be happy to use that.
I like the isValidOrFail()
idea, it's semantically clear and conforms to Laravel conventions. I could also see validate()
throwing an exception, but not sure if that has naming conflicts.
from validating.
isInvalid()
simply returns the inverse of isValid()
. I'll take a look at implementing isValidOrFail()
and isInvalidOrFail()
methods tonight. Can't have a validate()
method as it seems to conflict with a few other packages, one of which being Sentry I believe, would have to make it work with our performValidation
method.
from validating.
Tagged in 0.9.1
.
from validating.
Related Issues (20)
- custom validator HOT 6
- Update to laravel 5.7 HOT 1
- Add custom error to Model HOT 1
- A suggestion to improve performValidation() function HOT 5
- Question about usage HOT 1
- Column names in message bag spaces HOT 2
- [Sugestion] Add Validate Field HOT 1
- Just a note regarding the readme.md HOT 2
- Custom validation rule in the model HOT 1
- How to support different validations rules e.g. on update? HOT 1
- Laravel 6 Support
- Laravel 7.x support HOT 3
- Issue with Laravel 7.x custom Casts and validation HOT 4
- Support laravel 8 HOT 3
- ValidationException: Change $message when an ValidationException occurs during Tests? HOT 2
- Lost Laravel 6 support HOT 2
- MessageBag emtpy when using "Unique" rule on transaction HOT 2
- Add isEncryptedCastable HOT 4
- Validation of dynamic attributes during model creation HOT 3
- Failed requirements for Laravel-10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from validating.