Code Monkey home page Code Monkey logo

Comments (3)

dvcrn avatar dvcrn commented on May 23, 2024

How about change the API for configs from
[key value] to [key value opts].

    ["core.themes" ["nucleus-dark-ui" "zenburn"]]

could turn into

    ["core.themes" ["nucleus-dark-ui" "zenburn"] {:scope ["foo"]}]

But what do we do with proton configs that can't get assigned to a scope?

For the cljs code I think this is straight forward. We overload

(defn set-config! [selector value]
  (console! (str "Setting " selector " to " (clj->js value)))
  (.set config selector (clj->js value)))

To include a third parameter. I'll see if I can scribble something up.

from proton.

geksilla avatar geksilla commented on May 23, 2024

I also went with this approach, but since we convert configs to hashmap here we will lost third element {:scope ["foo"]} from vector.

from proton.

geksilla avatar geksilla commented on May 23, 2024

Fixed in #169

from proton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.