-Wmaybe-uninitialized about tiny-utf8 HOT 5 CLOSED

Hi Stuart,

Thank you for your message!
I'd be quite willing to accept such a change and would welcome a pull request 😃
However, I'd like to override the warning on a per-case basis. How many times does the warning occour? If it is less than let's say 3 times, I'd indeed prefer a per-case fix, with a small explanation of why the variable must have been initialized at each very point.
What do you think?

Best Regards,
Jakob

from tiny-utf8.

Yes, your suggested approach seems reasonable, and much more safe long term. I'll work on a pull request.

from tiny-utf8.

Cool, thanks a lot!

from tiny-utf8.

@DuffsDevice I spent a little bit of time on this, and I realized that fixing this with decreased scope, as you have suggested, started to get quite messy. I decided instead to simply disable forcing -Wmaybe-uninitialized to an error, and revert it back to only a warning, and only for the scope of a single header file.

Pull request #31.

from tiny-utf8.

Dear Stuart,

thanks for your efforts at exploring this direction. When I wanted to apply your solution, I realized, that GCC diagnostic warning will add the warning even if "-Wno-maybe-uninitialized" is being passed through the command line, kinda pittyful.
I guess, you convinced me, that the first solution you suggested in this issue is the right 😜.

Thanks a lot!
Jakob

Closed by Merging #31 in Commit 5827159

from tiny-utf8.