Comments (1)
For the underlying stat/geom:
I like the idea of stat_binhex()
by default + stat_density_2d()
when requested with something like do.contour
. Alternatively, or additionally only when color
is requested, we could use ggplot.multistats::geom_summaries_hex()
to show density through opacity, thus leaving color open for some other target variable. But, I'll just admit now that I have almost zero experience using any of these, so ¯_(ツ)_/¯. That's definitely why dittoSeq doesn't already have a hex-functionality.
For the implementation:
We could modify dittoScatterPlot to be the base, and it's what I'd always thought would happen.
But looking into the geoms more, I don't love the idea because there are quite a few inputs in dittoScatterPlot that are not applicable. Also, if there end up being hex specific inputs, these would need to be exposed within the dittoScatterPlot doc. I think that all then gets confusing for users, so I don't like it.
Ultimately, no matter how we implement, we'll need to have a separate .ditto_scatter_hex()
sub-function. Otherwise it'd get super dirty because half the code in .ditto_scatter_plot()
parses shape or color. (Shape is useless for hexPlots, and coloring is implemented quite differently from geom_point
, from what I can tell, for all hex geoms that handle it.)
So I propose we make a .scatter_data_gather() subfunction that would be shared between dittoScatterPlot()
and a dittoScatterHex()
. Then we can have .ditto_scatter_hex()
build the plot with whatever geoms we choose. And dittoDimHex()
can wrap around all that similarly to dittoDimPlot()
.
The "good news" here is that I don't think dittoDimHex()
will have as many extra overlays as dittoDimPlot()
-- really just the trajectory overlays -- so we could probably group dittoScatterHex()
and dittoDimHex()
together into a single piece of documentation.
And this is now implemented in #46
from dittoseq.
Related Issues (20)
- `scales = "free"` not properly respected in `split.adjust` when multiple vars provided to dittoPlot (and co) HOT 3
- Adding 'padding' to DotPlot rows to highlight differences across celltypes? HOT 6
- About HOT 3
- working with dataframe HOT 2
- have x-values sort numerically? HOT 3
- X values in dittoBarPlot not ordering according to x.reorder HOT 6
- Throw error if dimReds are NA HOT 3
- working with altExps HOT 14
- dittoHeatmap on "scale.data" and rowSums == 0 HOT 4
- Prepare for upcoming Seurat v5 release
- Changing titles on multi-plots / pseudo facet titles HOT 2
- How to remove median in boxplot? HOT 7
- Add parameter to control boxplot outlier size HOT 2
- Change colors of genes in dittoHeatmap HOT 4
- Error generating dittoheatmap HOT 2
- Dotplot on single gene split by two conditions HOT 5
- dittoHeatmap HOT 5
- dittoHeatmap with pale heat map colors HOT 1
- Support for Seurat V5? HOT 3
- Marker disappeared in the heatmap HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dittoseq.