Code Monkey home page Code Monkey logo

Comments (4)

dteviot avatar dteviot commented on July 17, 2024 3

@SpiralBaka

OK, I think (hope?) I've got it fixed.

Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.
Tested with:

For my notes: 99 minutes work
That really wasn't fun. There were 3 separate bugs.

  1. host can be "questionablequesting.com" and "forum.questionablequesting.com"
  2. did not correctly handle case of no "data-url" property
  3. common code in ImageCollector was overriding fixed value

from webtoepub.

dteviot avatar dteviot commented on July 17, 2024

@SpiralBaka
Looks like a fix was posted for this #1112.
Version in stores has not been updated with this fix yet. Only the Test versions have it.

Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.

Note, I have not verified it works for the supplied URL, as I can't access it. I think I need an account on the site.

from webtoepub.

SpiralBaka avatar SpiralBaka commented on July 17, 2024

it still doesn't work.
but I got a new info, this one also applies to previous version:
it works for images that isn't in spoiler tag, but doesn't work for one inside a spoiler tag.

example of one that works:
https://forum.questionablequesting.com/threads/an-arc-for-every-season-team-rwby-maiden-fic.24830/
https://forum.questionablequesting.com/threads/another-way-pok%C3%A9mon-mystery-dungeon-oc-isekai.23106/
the images in those two worked.

example of one that doesn't work:
https://forum.questionablequesting.com/threads/ice-pie-spyxfamily-si.10724/
'chapter seven and eight' has one image in spoiler tag. it doesn't work.

https://forum.questionablequesting.com/threads/shiro-tokita-has-a-weird-visitor-evangelion-fanfic-canon-character-protagonist-og-eva-rebuilds.21905/
the prologue, chapter 3, 4, and many other, has many images in spoiler tag, none worked.

you should be able to test those, since they're not in nsfw section. in fact, I tested them in private browsing.

from webtoepub.

dteviot avatar dteviot commented on July 17, 2024

@SpiralBaka

Updated version (0.0.0.157) has been submitted to Firefox and Chrome stores.
Firefox version is available now.
Chrome might be available in 3 to 21 days.

from webtoepub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.