Use ordered dictionary to generate JSON about vcrurlconnection HOT 5 CLOSED

I loved VCR when writing Ruby tests, and I've stumbled upon this project. I'd love to help out if I can. I've used an ordered dictionary implementation or two before — by ordered dictionary, do you mean replacing this ivar here?

https://github.com/dstnbrkr/VCRURLConnection/blob/master/VCRURLConnection/VCRCassette_Private.h#L28

#import "VCRCassette.h"

@interface VCRCassette ()

@property (nonatomic, retain) NSMutableDictionary *responseDictionary;

@end

from vcrurlconnection.

Hi @kreeger, that would be great! This is the dictionary that should probably be ordered:

https://github.com/dstnbrkr/VCRURLConnection/blob/master/VCRURLConnection/VCRRecording.m#L87

if that dictionary was ordered, then the keys in the generated JSON would appear in consistent order. The dictionary here:

https://github.com/dstnbrkr/VCRURLConnection/blob/master/VCRURLConnection/VCRCassette_Private.h#L28

is just the url / response map, which doesn't need ordering.

from vcrurlconnection.

Question — I'm writing a test case to cover this new functionality (both'll be included in my PR), but there are three tests that fail on master before I even apply my changes, on both the OS X and iOS test targets. Should I worry about those? Fix those?

from vcrurlconnection.

I've added my own passing test for the JSON key ordering bit — opening a pull request now.

from vcrurlconnection.

I see what you mean re: those tests, should be fixed in master now. Thanks!

from vcrurlconnection.